⚠️ Replace Helm binary with pure go packages based solution #34
Conversation
Closes: #33 Signed-off-by: Tobias Wolf <[email protected]>
…nf()" Signed-off-by: Tobias Wolf <[email protected]>
|
@NotTheEvilOne I am looking at your PR. I looked at the change and it looks good. I will test today. Sorry, for the delay. The main branch was updated and there are conflicts. Do you have time to solve them? Otherwise, I can work on that, too. |
Signed-off-by: Tobias Wolf <[email protected]>
There was a problem hiding this comment.
@NotTheEvilOne please tell me how you want to proceed. You can rebase your PR on the current main branch, and inline helmTemplate(). Or I will do that. Please tell me what you prefer. Thank you.
NotTheEvilOne
force-pushed
the
prs/replace-helm-bin
branch
2 times, most recently
from
86ddf68
to
fbdc30d
Compare
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
prs/replace-helm-bin
branch
from
fbdc30d
to
c74db63
Compare
|
@NotTheEvilOne please merge the 4 commits into one commit. Then I can approve and merge it. Thank you. |
jschoone
added
the
Container
Hi @NotTheEvilOne and @guettli is this still planned to be merged or is it now outdated? |
What this PR does / why we need it:
This PR replaces the Helm binary with a pure go packages based solution
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Closes: #33