Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo-rollup restart issue #360

Merged
merged 4 commits into from
May 30, 2023
Merged

Fix demo-rollup restart issue #360

merged 4 commits into from
May 30, 2023

Conversation

citizen-stig
Copy link
Member

Description

Adds is_empty method to Storage trait so it can be checked during initialization.

Linked Issues

Testing

Added unit tests with restart lifecycle

Docs

Trait documentation has been updated

@citizen-stig citizen-stig self-assigned this May 30, 2023
@citizen-stig citizen-stig requested review from dubbelosix, bkolad and preston-evans98 and removed request for dubbelosix and bkolad May 30, 2023 16:15
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #360 (59b84dc) into main (f5b4bd4) will increase coverage by 0.1%.
The diff coverage is 93.5%.

❗ Current head 59b84dc differs from pull request most recent head 5292034. Consider uploading reports for the commit 5292034 to get more accurate results

Impacted Files Coverage Δ
full-node/db/sov-schema-db/src/lib.rs 85.3% <ø> (ø)
module-system/sov-state/src/storage.rs 100.0% <ø> (ø)
module-system/sov-state/src/zk_storage.rs 75.0% <0.0%> (-2.6%) ⬇️
module-system/sov-state/src/prover_storage.rs 95.9% <100.0%> (+0.8%) ⬆️

... and 1 file with indirect coverage changes

@citizen-stig citizen-stig merged commit 04c72fe into main May 30, 2023
@citizen-stig citizen-stig deleted the fix/fix_runner_restart branch May 30, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo rollup and prover fails after restart
2 participants