Reworking archiving job logic #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatrickOtero
requested review from
rigonlucas,
EddieSCJ and
JoaoPauloAmendolaDev
rigonlucas
approved these changes
Jan 31, 2024
| } | ||
|
|
||
| jobExists.status = "ARCHIVED" | ||
|
|
There was a problem hiding this comment.
Uma adição que pode agregar ao teu conhecimento:
Não tenho muito contexto do projeto. Mas existe um patthern para realizar exclusões lógicas chamada soft delete.
Basicamente vc tem uma coluna do tipo datetime chamada deleted_at que quando null está ativo, quando contém uma data está excluído.
Para arquivar vc pode usar o archived_at com a mesma lógica.
There was a problem hiding this comment.
Excelente sugestão. Vou adicionar a ideia na estrutura.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was simplified and some semantic issues were fixed. Now everything refers to that feature as "Archive job" not "Delete Job" as it were before. Also, the respective swagger route is fixed, now showing the id parameter correctly.