Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedubuddy cog 2024-25 compliance #87

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AaryanHazCompter
Copy link

@AaryanHazCompter AaryanHazCompter commented Apr 5, 2024

The Schedubuddy cog has accounted for 2023-24 cases up until now, made minor changes to continue compliance for the upcoming year.

ETA Sherpmail:
I saw an issue Ian raised about wanting a way to (a) communicate to the server through the bot (b) have the server communicate to him through the bot; the idea seemed funny enough so I coded it - there's little error handling, no accounting for excess characters, no graphics and attachment handling, and definitely no spam prevention - however I am sleep deprived and wanted to make what is basically a letter mail system work to a reasonable extent.

The Schedubuddy cog has accounted for 2023-24 cases up until now, made minor changes to continue compliance for the upcoming year.
I saw an issue Ian raised about wanting a way to (a) communicate to the server through the bot (b) have the server communicate to him through the bot and the idea seemed funny so I coded it - there's little error handling, no accounting for excess characters, no graphics and attachment handling, and definitely no spam prevention - however I am sleep deprived and wanted to make what is basically a letter mail system work to a reasonable extent.
@Sooraj-beep
Copy link
Owner

Oooo I love the name sherpmail. However, could u split this into two separate prs? One for schedubuddy and the other for sherpmail. Thanks!

This reverts commit 10d1e4d.
Reaction events now fire on uncached messages (Sooraj-beep#86)
@AaryanHazCompter
Copy link
Author

Thanks Sooraj, I haven't really used GitHub that much before taking this on, so I hope you don't mind as I navigate these unique challenges. I've reverted the sherpmail addition in this PR and created a second one, but I am a bit confused as it appears as if I had to factor in Jad's commit too. Let me know if I need to do something else!

@Sooraj-beep
Copy link
Owner

No worries! No better time to learn than when contributing to an open source discord not tin by a bunch of Uni students 😂. If you are seeing Jads change it could be that your branch is not aware that changes were made to origin. You can fix this by pulling from origin and merging those changes to your branch, then making a pr. Let me know if this solves your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants