Self timeout command #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mattwmaster58
approved these changes
Apr 1, 2024
| @@ -64,6 +66,35 @@ async def sync(self, ctx): | |||
| async def eight_ball(self, ctx): | |||
| await ctx.send(random.choice(self.eight_ball_options)) | |||
|
|
|||
| @commands.command(name="zipit") | |||
There was a problem hiding this comment.
suggestion: name this "lockin" instead
| value = int(match.group(1)) * v["duration"] | ||
| total_duration += datetime.timedelta(minutes=value) | ||
|
|
||
| if total_duration.seconds == 0: |
There was a problem hiding this comment.
maybe set an upper bound to like 2w? to protect users
|
Why not add this command as a slash command? |
|
I have a personal bias against slash commands. But it's a good point, should probably be a slash command. There's no need for speed which is necessary for commands like snipe. |
|
I didn’t really think about speed. For me, it was more about the convenience that slash cmds provide. I think we should migrate cmds which don’t have to be fast to slash cmds, and make new ones slash cmds as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?zipit 3d3hto time out yourself for 3 days 3 hoursIdea by @Mattwmaster58