Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http & Related Components #57

Closed
wants to merge 33 commits into from
Closed

Conversation

JoshuaEstes
Copy link
Member

@JoshuaEstes JoshuaEstes commented Oct 27, 2023

Description

Adds the components: Http, HttpClient, HttpFactory, HttpHandler, HttpMessage

fixes #53

Checklist

  • Updated the correct CHANGELOG file
  • Updated documentation
  • Code Coverage >= 80%
  • HttpMessage constructor arguments should match the HttpFactory creation method arguments
  • All @todo comments have been completed and removed
  • Psalm issues fixed, baseline updated

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 29, 2023
@JoshuaEstes
Copy link
Member Author

HttpHandler should be changed to HttpServerHandler, might just want to drop this out since this is getting to be a very large PR. This can be done later and doesn't really seem to fit nicely within the context of the other components.

@JoshuaEstes
Copy link
Member Author

HttpMessage and HttpFactory should be ready to be released, given the amount of time it will take to get HttpClient working, might be best to just release Http, HttpMessage, and HttpFactory.

@JoshuaEstes
Copy link
Member Author

Release HttpFactory and HttpMessage. Add more tests to these two components to make sure everything works as expected as well. HttpClient will get released later, Http may or may not get a release.

@JoshuaEstes
Copy link
Member Author

Release HttpFactory and HttpMessage. Add more tests to these two components to make sure everything works as expected as well. HttpClient will get released later, Http may or may not get a release.

Do a PR for each component, update terraform repo as well

@JoshuaEstes JoshuaEstes added this to the v1.x milestone Nov 5, 2023
@JoshuaEstes JoshuaEstes deleted the http branch November 14, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Component: Http and Related
1 participant