Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] New Component and Contract #176

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JoshuaEstes
Copy link
Member

Description

Checklist

  • Updated CHANGELOG files
  • Updated Documentation
  • Unit Tests Created
  • php-cs-fixer

@github-actions github-actions bot added documentation Improvements or additions to documentation Contracts labels Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (4219657) 72.86% compared to head (454f3a2) 72.78%.

Files Patch % Lines
...SonsOfPHP/Component/Search/Backend/MockBackend.php 0.00% 6 Missing ⚠️
src/SonsOfPHP/Component/Search/Search.php 0.00% 5 Missing ⚠️
...SonsOfPHP/Component/Search/Backend/NullBackend.php 0.00% 2 Missing ⚠️
src/SonsOfPHP/Component/Search/Query.php 93.93% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #176      +/-   ##
============================================
- Coverage     72.86%   72.78%   -0.09%     
- Complexity     1220     1247      +27     
============================================
  Files           195      199       +4     
  Lines          3051     3097      +46     
============================================
+ Hits           2223     2254      +31     
- Misses          828      843      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaEstes JoshuaEstes linked an issue Nov 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search] New Component and Contracts
2 participants