Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] 0.10.8 #149

Merged
merged 3 commits into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sgcop/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Sgcop
VERSION = '0.10.7'.freeze
VERSION = '0.10.8'.freeze
end
30 changes: 30 additions & 0 deletions rails/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@ Performance/MapCompact: # (new in 1.11)
# https://docs.rubocop.org/rubocop-performance/cops_performance.html#performanceconcurrentmonotonictime
Performance/ConcurrentMonotonicTime: # new in 1.12
Enabled: true
# https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancemapmethodchain
Performance/MapMethodChain: # new in 1.19
Enabled: true

# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsactiverecordcallbacksorder
Rails/ActiveRecordCallbacksOrder:
Expand Down Expand Up @@ -421,6 +424,18 @@ Rails/ResponseParsedBody: # new in 2.18
# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsthreestatebooleancolumn
Rails/ThreeStateBooleanColumn: # new in 2.19
Enabled: true
# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsdangerouscolumnnames
Rails/DangerousColumnNames: # new in 2.21
Enabled: true
# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsredundantactiverecordallmethod
Rails/RedundantActiveRecordAllMethod: # new in 2.21
Enabled: true
# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsselectmap
Rails/SelectMap: # new in 2.21
Enabled: true
# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsunusedrendercontent
Rails/UnusedRenderContent: # new in 2.21
Enabled: true

# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecidenticalequalityassertion
RSpec/IdenticalEqualityAssertion: # (new in 2.4)
Expand Down Expand Up @@ -534,6 +549,21 @@ RSpec/ReceiveMessages: # new in 2.23
# https://docs.rubocop.org/rubocop-rspec/cops_rspec_rails.html#rspecrailsnegationbevalid
RSpec/Rails/NegationBeValid: # new in 2.23
Enabled: true
# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecemptymetadata
RSpec/EmptyMetadata: # new in 2.24
Enabled: true
# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspeceq
RSpec/Eq: # new in 2.24
Enabled: true
# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecmetadatastyle
RSpec/MetadataStyle: # new in 2.24
Enabled: true
# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecspecfilepathformat
RSpec/SpecFilePathFormat: # new in 2.24
Enabled: true
# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecspecfilepathsuffix
RSpec/SpecFilePathSuffix: # new in 2.24
Enabled: true

# https://docs.rubocop.org/rubocop/cops_factorybot.html#factorybotassociationstyle
FactoryBot/AssociationStyle: # new in 2.23
Expand Down
6 changes: 3 additions & 3 deletions sgcop.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ Gem::Specification.new do |spec|
spec.add_dependency 'rubocop', '~> 1.56.0'
spec.add_dependency 'rubocop-capybara', '~> 2.18.0'
spec.add_dependency 'rubocop-factory_bot', '~> 2.23.1'
spec.add_dependency 'rubocop-performance', '~> 1.18.0'
spec.add_dependency 'rubocop-rails', '~> 2.20.0'
spec.add_dependency 'rubocop-performance', '~> 1.19.0'
spec.add_dependency 'rubocop-rails', '~> 2.21.0'
spec.add_dependency 'rubocop-rake', '~> 0.6.0'
spec.add_dependency 'rubocop-rspec', '~> 2.23.1'
spec.add_dependency 'rubocop-rspec', '~> 2.24.0'
end