Merge pull request #133 from SonicGarden/0.8.5

[review] 0.8.5

.github/dependabot.yml

@@ -0,0 +1,7 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      # Check for updates to GitHub Actions every weekday
+      interval: "weekly"

.github/workflows/rspec.yml

@@ -0,0 +1,26 @@
+name: Ruby
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+
+jobs:
+  rspec:
+    runs-on: ubuntu-latest
+    env:
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["3.0", "3.1", "3.2"]
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run rspec
+        run: bundle exec rspec

lib/sgcop/version.rb

@@ -1,3 +1,3 @@
 module Sgcop
-  VERSION = '0.8.4'.freeze
+  VERSION = '0.8.5'.freeze
 end

ruby/rubocop.yml

@@ -393,6 +393,12 @@ Style/DirEmpty: # new in 1.48
 # https://docs.rubocop.org/rubocop/cops_style.html#stylefileempty
 Style/FileEmpty: # new in 1.48
   Enabled: true
+# https://docs.rubocop.org/rubocop/cops_style.html#styledatainheritance
+Style/DataInheritance: # new in 1.49
+  Enabled: true
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantlinecontinuation
+Style/RedundantLineContinuation: # new in 1.49
+  Enabled: true
 
 # ============================================================
 # Lint

sgcop.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.48.0'
+  spec.add_dependency 'rubocop', '~> 1.49.0'
   spec.add_dependency 'rubocop-capybara', '~> 2.17.0'
   spec.add_dependency 'rubocop-performance', '~> 1.16.0'
   spec.add_dependency 'rubocop-rails', '~> 2.18.0'

spec/rubocop/cop/sgcop/capybara/sleep_spec.rb

@@ -8,7 +8,7 @@
       it do
         click_on 'button'
         sleep 10
-        ^^^^^ Do not use `sleep` in spec.
+        ^^^^^ Sgcop/Capybara/Sleep: Do not use `sleep` in spec.
       end
     RUBY
   end
@@ -18,7 +18,7 @@
       it do
         click_on 'button'
         Kernel.sleep 10
-               ^^^^^ Do not use `sleep` in spec.
+               ^^^^^ Sgcop/Capybara/Sleep: Do not use `sleep` in spec.
       end
     RUBY
   end

spec/rubocop/cop/sgcop/link_to_ujs_options_spec.rb

@@ -7,14 +7,14 @@
   it 'methodオプションは警告' do
     expect_offense(<<~RUBY)
       link_to 'title', url, method: :delete
-      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Deprecated: Rails UJS Attributes.
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sgcop/UjsOptions: Deprecated: Rails UJS Attributes.
     RUBY
   end
 
   it 'remoteオプションは警告' do
     expect_offense(<<~RUBY)
       link_to 'title', url, remote: true
-      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Deprecated: Rails UJS Attributes.
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sgcop/UjsOptions: Deprecated: Rails UJS Attributes.
     RUBY
   end
 

spec/rubocop/cop/sgcop/request_remote_ip_spec.rb

@@ -7,7 +7,7 @@
     expect_offense(<<~RUBY)
       def log
         logger.info request.remote_addr
-                    ^^^^^^^^^^^^^^^^^^^ Use `request.remote_ip` instead of `request.remote_addr`.
+                    ^^^^^^^^^^^^^^^^^^^ Sgcop/RequestRemoteIp: Use `request.remote_ip` instead of `request.remote_addr`.
       end
     RUBY
   end

spec/rubocop/cop/sgcop/simple_form_association_spec.rb

@@ -8,7 +8,7 @@
       expect_offense(<<~RUBY)
         simple_form_for user do |f|
           f.association :group
-          ^^^^^^^^^^^^^^^^^^^^ Specify the `collection` option
+          ^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormAssociation: Specify the `collection` option
         end
       RUBY
     end
@@ -35,7 +35,7 @@
       expect_offense(<<~RUBY)
         simple_nested_form_for user do |f|
           f.association :group
-          ^^^^^^^^^^^^^^^^^^^^ Specify the `collection` option
+          ^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormAssociation: Specify the `collection` option
         end
       RUBY
     end
@@ -63,7 +63,7 @@
         simple_form_for user do |f|
           f.simple_fields_for :posts do |ff|
             ff.association :category
-            ^^^^^^^^^^^^^^^^^^^^^^^^ Specify the `collection` option
+            ^^^^^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormAssociation: Specify the `collection` option
           end
         end
       RUBY

spec/rubocop/cop/sgcop/simple_format_spec.rb

@@ -7,7 +7,7 @@
     expect_offense(<<~RUBY)
       def html_format(text)
         simple_format(text)
-        ^^^^^^^^^^^^^^^^^^^ simple_format does not escape HTML tags.
+        ^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormat: simple_format does not escape HTML tags.
       end
     RUBY
   end
@@ -16,7 +16,7 @@ def html_format(text)
     expect_offense(<<~RUBY)
       def html_format(object)
         simple_format(object.body)
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^ simple_format does not escape HTML tags.
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormat: simple_format does not escape HTML tags.
       end
     RUBY
   end
@@ -30,21 +30,21 @@ def html_format(object)
   it 'simple_formatにエスケープメソッド以外の結果が渡されていたら警告' do
     expect_offense(<<~RUBY)
       simple_format(t(text))
-      ^^^^^^^^^^^^^^^^^^^^^^ simple_format does not escape HTML tags.
+      ^^^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormat: simple_format does not escape HTML tags.
     RUBY
   end
 
   it 'simple_formatにインスタンス変数が渡されていたら警告' do
     expect_offense(<<~RUBY)
       simple_format(@object)
-      ^^^^^^^^^^^^^^^^^^^^^^ simple_format does not escape HTML tags.
+      ^^^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormat: simple_format does not escape HTML tags.
     RUBY
   end
 
   it 'simple_formatにインスタンス変数のメソッドが渡されていたら警告' do
     expect_offense(<<~RUBY)
       simple_format(@object.body)
-      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ simple_format does not escape HTML tags.
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sgcop/SimpleFormat: simple_format does not escape HTML tags.
     RUBY
   end
 end

spec/rubocop/cop/sgcop/unscoped_spec.rb

@@ -8,7 +8,7 @@
       class BooksController < ApplicationController
         def index
           @books = books.unscoped.default_order
-                   ^^^^^^^^^^^^^^ Do not use `unscoped`
+                   ^^^^^^^^^^^^^^ Sgcop/Unscoped: Do not use `unscoped`
         end
       end
     RUBY

spec/rubocop/cop/sgcop/whenever_spec.rb

@@ -9,7 +9,7 @@
       set :chronic_options, hours24: true
 
       every 1.day, at: '7:10 am' do
-                   ^^^^^^^^^^^^^ Use 24-hour clock to avoid errors.
+                   ^^^^^^^^^^^^^ Sgcop/Whenever: Use 24-hour clock to avoid errors.
       rake 'sgcop'
     end
     RUBY