[review] EventBride Scheduler (State Machine) の input に指定する JSON を修正 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interu
reviewed
Jun 28, 2024
| @@ -86,6 +86,14 @@ def input_overrides_json | |||
| }.to_json | |||
| end | |||
|
|
|||
| def input_overrides_json_for_state_machine | |||
There was a problem hiding this comment.
Suggested change
| def input_overrides_json_for_state_machine | |
| def container_overrides_json |
とかでもわかりやすいかも。
There was a problem hiding this comment.
container overrides の name がないから厳密には違いそうなんですよね
There was a problem hiding this comment.
いや、でも state machine の中では container overrides になるのかな？
とりあえず↑のメソッド名にしておきます
interu
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.