Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] ERB.new引数の非推奨警告対応 #92

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[review] ERB.new引数の非推奨警告対応 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dcfabe
fix: ERB.new引数の非推奨警告対応
aki77 Apr 23, 2024
856169c
0.17.1
aki77 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/copy_tuner_client/request_sync.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def render_with_layout(view)
# you have to pass a binding to this (a proc) so that ERB can have
# access to helper functions and local variables
def render_without_layout(view, binding)
ERB.new(File.read(File.join(VIEW_PATH, 'copytuner', view.to_s + '.html.erb')), nil, nil, 'frobnitz').result(binding)
ERB.new(File.read(File.join(VIEW_PATH, 'copytuner', view.to_s + '.html.erb')), eoutvar: 'frobnitz').result(binding)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この件ね。
https://qiita.com/jnchito/items/bcd9b7f59bf4b30ea5b3#erbinitialize-%E3%81%AE%E7%AC%AC2%E5%BC%95%E6%95%B0%E4%BB%A5%E9%99%8D%E3%81%8C%E5%B8%B8%E3%81%AB%E8%AD%A6%E5%91%8A%E3%82%92%E5%87%BA%E3%81%99%E3%82%88%E3%81%86%E3%81%AB%E3%81%AA%E3%81%A3%E3%81%9F

end

def cancel_sync?(env)
Expand Down
2 changes: 1 addition & 1 deletion lib/copy_tuner_client/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module CopyTunerClient
# Client version
VERSION = '0.17.0'.freeze
VERSION = '0.17.1'.freeze

# API version being used to communicate with the server
API_VERSION = '2.0'.freeze
Expand Down
Loading