refactor(test): handle a breaking change from Jest 29 with jest.mocked

Sonia-corporation · Mar 12, 2023 · b47b5ef · b47b5ef
1 parent 88764fd
commit b47b5ef
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 54 deletions.
diff --git a/src/core/processing/issues/issue-processor.spec.ts b/src/core/processing/issues/issue-processor.spec.ts
@@ -438,10 +438,8 @@ describe(`IssueProcessor`, (): void => {
     });
 
     describe(`shouldIgnore$$()`, (): void => {
-      const mockedIssueIgnoreProcessor: MockedObjectDeep<typeof IssueIgnoreProcessor> = jest.mocked(
-        IssueIgnoreProcessor,
-        true
-      );
+      const mockedIssueIgnoreProcessor: MockedObjectDeep<typeof IssueIgnoreProcessor> =
+        jest.mocked(IssueIgnoreProcessor);
 
       beforeEach((): void => {
         mockedIssueIgnoreProcessor.mockClear();
@@ -490,10 +488,7 @@ describe(`IssueProcessor`, (): void => {
     });
 
     describe(`processForStale$$()`, (): void => {
-      const mockedIssueStaleProcessor: MockedObjectDeep<typeof IssueStaleProcessor> = jest.mocked(
-        IssueStaleProcessor,
-        true
-      );
+      const mockedIssueStaleProcessor: MockedObjectDeep<typeof IssueStaleProcessor> = jest.mocked(IssueStaleProcessor);
 
       let stopProcessingSpy: jest.SpyInstance;
       let issuesStatisticsServiceIncreaseStaleIssuesCountSpy: jest.SpyInstance;
@@ -598,10 +593,8 @@ describe(`IssueProcessor`, (): void => {
     });
 
     describe(`isAlreadyStale$$()`, (): void => {
-      const mockedIssueIsStaleProcessor: MockedObjectDeep<typeof IssueIsStaleProcessor> = jest.mocked(
-        IssueIsStaleProcessor,
-        true
-      );
+      const mockedIssueIsStaleProcessor: MockedObjectDeep<typeof IssueIsStaleProcessor> =
+        jest.mocked(IssueIsStaleProcessor);
 
       beforeEach((): void => {
         mockedIssueIsStaleProcessor.mockClear();
@@ -650,10 +643,8 @@ describe(`IssueProcessor`, (): void => {
     describe(`processToRemoveStale$$()`, (): void => {
       let issuesStatisticsServiceIncreaseRemoveStaleIssuesCountSpy: jest.SpyInstance;
 
-      const mockedIssueRemoveStaleProcessor: MockedObjectDeep<typeof IssueRemoveStaleProcessor> = jest.mocked(
-        IssueRemoveStaleProcessor,
-        true
-      );
+      const mockedIssueRemoveStaleProcessor: MockedObjectDeep<typeof IssueRemoveStaleProcessor> =
+        jest.mocked(IssueRemoveStaleProcessor);
 
       beforeEach((): void => {
         mockedIssueRemoveStaleProcessor.mockClear();
@@ -738,14 +729,10 @@ describe(`IssueProcessor`, (): void => {
     });
 
     describe(`processForClose$$()`, (): void => {
-      const mockedIssueShouldCloseProcessor: MockedObjectDeep<typeof IssueShouldCloseProcessor> = jest.mocked(
-        IssueShouldCloseProcessor,
-        true
-      );
-      const mockedIssueCloseStaleProcessor: MockedObjectDeep<typeof IssueCloseStaleProcessor> = jest.mocked(
-        IssueCloseStaleProcessor,
-        true
-      );
+      const mockedIssueShouldCloseProcessor: MockedObjectDeep<typeof IssueShouldCloseProcessor> =
+        jest.mocked(IssueShouldCloseProcessor);
+      const mockedIssueCloseStaleProcessor: MockedObjectDeep<typeof IssueCloseStaleProcessor> =
+        jest.mocked(IssueCloseStaleProcessor);
 
       let stopProcessingSpy: jest.SpyInstance;
       let issuesStatisticsServiceIncreaseClosedIssuesCountSpy: jest.SpyInstance;

diff --git a/src/core/processing/issues/issues.service.spec.ts b/src/core/processing/issues/issues.service.spec.ts
@@ -110,8 +110,8 @@ describe(`IssuesService`, (): void => {
   });
 
   describe(`processBatch()`, (): void => {
-    const mockedIssueProcessor: MockedObjectDeep<typeof IssueProcessor> = jest.mocked(IssueProcessor, true);
-    const mockedIssueLogger: MockedObjectDeep<typeof IssueLogger> = jest.mocked(IssueLogger, true);
+    const mockedIssueProcessor: MockedObjectDeep<typeof IssueProcessor> = jest.mocked(IssueProcessor);
+    const mockedIssueLogger: MockedObjectDeep<typeof IssueLogger> = jest.mocked(IssueLogger);
 
     let githubApiIssuesServiceFetchIssuesSpy: jest.SpyInstance;
     let loggerServiceInfoSpy: jest.SpyInstance;

diff --git a/src/core/processing/pull-requests/pull-request-processor.spec.ts b/src/core/processing/pull-requests/pull-request-processor.spec.ts
@@ -445,10 +445,8 @@ describe(`PullRequestProcessor`, (): void => {
     });
 
     describe(`shouldIgnore$$()`, (): void => {
-      const mockedPullRequestIgnoreProcessor: MockedObjectDeep<typeof PullRequestIgnoreProcessor> = jest.mocked(
-        PullRequestIgnoreProcessor,
-        true
-      );
+      const mockedPullRequestIgnoreProcessor: MockedObjectDeep<typeof PullRequestIgnoreProcessor> =
+        jest.mocked(PullRequestIgnoreProcessor);
 
       beforeEach((): void => {
         mockedPullRequestIgnoreProcessor.mockClear();
@@ -497,14 +495,10 @@ describe(`PullRequestProcessor`, (): void => {
     });
 
     describe(`processForStale$$()`, (): void => {
-      const mockedPullRequestStaleProcessor: MockedObjectDeep<typeof PullRequestStaleProcessor> = jest.mocked(
-        PullRequestStaleProcessor,
-        true
-      );
-      const mockedPullRequestDraftProcessor: MockedObjectDeep<typeof PullRequestDraftProcessor> = jest.mocked(
-        PullRequestDraftProcessor,
-        true
-      );
+      const mockedPullRequestStaleProcessor: MockedObjectDeep<typeof PullRequestStaleProcessor> =
+        jest.mocked(PullRequestStaleProcessor);
+      const mockedPullRequestDraftProcessor: MockedObjectDeep<typeof PullRequestDraftProcessor> =
+        jest.mocked(PullRequestDraftProcessor);
 
       let stopProcessingSpy: jest.SpyInstance;
       let pullRequestsStatisticsServiceIncreaseStalePullRequestsCountSpy: jest.SpyInstance;
@@ -679,10 +673,8 @@ describe(`PullRequestProcessor`, (): void => {
     });
 
     describe(`isAlreadyStale$$()`, (): void => {
-      const mockedPullRequestIsStaleProcessor: MockedObjectDeep<typeof PullRequestIsStaleProcessor> = jest.mocked(
-        PullRequestIsStaleProcessor,
-        true
-      );
+      const mockedPullRequestIsStaleProcessor: MockedObjectDeep<typeof PullRequestIsStaleProcessor> =
+        jest.mocked(PullRequestIsStaleProcessor);
 
       beforeEach((): void => {
         mockedPullRequestIsStaleProcessor.mockClear();
@@ -732,7 +724,7 @@ describe(`PullRequestProcessor`, (): void => {
       let pullRequestsStatisticsServiceIncreaseRemoveStalePullRequestsCountSpy: jest.SpyInstance;
 
       const mockedPullRequestRemoveStaleProcessor: MockedObjectDeep<typeof PullRequestRemoveStaleProcessor> =
-        jest.mocked(PullRequestRemoveStaleProcessor, true);
+        jest.mocked(PullRequestRemoveStaleProcessor);
 
       beforeEach((): void => {
         mockedPullRequestRemoveStaleProcessor.mockClear();
@@ -818,11 +810,9 @@ describe(`PullRequestProcessor`, (): void => {
 
     describe(`processForClose$$()`, (): void => {
       const mockedPullRequestShouldCloseProcessor: MockedObjectDeep<typeof PullRequestShouldCloseProcessor> =
-        jest.mocked(PullRequestShouldCloseProcessor, true);
-      const mockedPullRequestCloseStaleProcessor: MockedObjectDeep<typeof PullRequestCloseStaleProcessor> = jest.mocked(
-        PullRequestCloseStaleProcessor,
-        true
-      );
+        jest.mocked(PullRequestShouldCloseProcessor);
+      const mockedPullRequestCloseStaleProcessor: MockedObjectDeep<typeof PullRequestCloseStaleProcessor> =
+        jest.mocked(PullRequestCloseStaleProcessor);
 
       let stopProcessingSpy: jest.SpyInstance;
       let pullRequestsStatisticsServiceIncreaseClosedPullRequestsCountSpy: jest.SpyInstance;
@@ -948,7 +938,7 @@ describe(`PullRequestProcessor`, (): void => {
 
     describe(`processToDeleteBranch$$()`, (): void => {
       const mockedPullRequestDeleteBranchProcessor: MockedObjectDeep<typeof PullRequestDeleteBranchProcessor> =
-        jest.mocked(PullRequestDeleteBranchProcessor, true);
+        jest.mocked(PullRequestDeleteBranchProcessor);
 
       beforeEach((): void => {
         mockedPullRequestDeleteBranchProcessor.mockClear();

diff --git a/src/core/processing/pull-requests/pull-requests.service.spec.ts b/src/core/processing/pull-requests/pull-requests.service.spec.ts
@@ -110,11 +110,8 @@ describe(`PullRequestsService`, (): void => {
   });
 
   describe(`processBatch()`, (): void => {
-    const mockedPullRequestProcessor: MockedObjectDeep<typeof PullRequestProcessor> = jest.mocked(
-      PullRequestProcessor,
-      true
-    );
-    const mockedPullRequestLogger: MockedObjectDeep<typeof PullRequestLogger> = jest.mocked(PullRequestLogger, true);
+    const mockedPullRequestProcessor: MockedObjectDeep<typeof PullRequestProcessor> = jest.mocked(PullRequestProcessor);
+    const mockedPullRequestLogger: MockedObjectDeep<typeof PullRequestLogger> = jest.mocked(PullRequestLogger);
 
     let githubApiPullRequestsServiceFetchPullRequestsSpy: jest.SpyInstance;
     let loggerServiceInfoSpy: jest.SpyInstance;