SLI-1589 Improve UI thread usage - Round 1 #1162
Conversation
nquinquenel
force-pushed
the
task/nq/SLI-1589-thread-improvement
branch
4 times, most recently
from
ccb47f8 to
ad40e0a
Compare
nquinquenel
force-pushed
the
task/nq/SLI-1589-thread-improvement
branch
from
ad40e0a to
639d1c9
Compare
|
| public void openReportTab(AnalysisResult analysisResult) { | ||
| this.<ReportPanel>openTab(SonarLintToolWindowFactory.REPORT_TAB_TITLE, panel -> panel.updateFindings(analysisResult)); | ||
| runOnUiThread(project, ModalityState.stateForComponent(getToolWindow().getComponent()), | ||
| () -> this.<ReportPanel>openTab(SonarLintToolWindowFactory.REPORT_TAB_TITLE, panel -> panel.updateFindings(analysisResult))); |
There was a problem hiding this comment.
inside update findings we are doing a mapping for new code old code which I think can be done outside of the UI thread
There was a problem hiding this comment.
I'm dropping this from this PR
|
|
||
| fun show() { | ||
| val fileEditorManager = FileEditorManager.getInstance(project) | ||
| val psiFile = PsiManager.getInstance(project).findFile(file) ?: return |
There was a problem hiding this comment.
In the documentation, it is mentioned that psi file operations should not be done on the UI thread. Why are we moving these back to the UI thread again?
There was a problem hiding this comment.
PsiManager.getInstance(project).findFile(file) requires to have read access
There was a problem hiding this comment.
Yes but we don't need UI Thread access, this operation should not be done on UI Thread
There was a problem hiding this comment.
Right, can move to read access only
SLI-1589