Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scanner engine library #242

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

leonardo-pilastri-sonarsource
Copy link
Contributor

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (MSONAR-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

var props = System.getProperties();
//please copilot, save properties to a file
try {
props.store(Files.newOutputStream(sensorContext.fileSystem().workDir().toPath().resolve("dumpSensor.properties")), null);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, would it make sense to rename this file dumpSensor.systemproperties?

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource force-pushed the lp/update-scanner-lib branch 2 times, most recently from 55a1f51 to 3b73f13 Compare October 18, 2024 07:49
.cirrus.yml Outdated
@@ -50,6 +50,7 @@ build_task:
script:
- source cirrus-env BUILD
- regular_mvn_build_deploy_analyze
- mvn -f property-dump-plugin/pom.xml install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move one line up

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource force-pushed the lp/update-scanner-lib branch 2 times, most recently from b6dc365 to f1b482c Compare October 18, 2024 08:41
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
93.9% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants