SONARPY-2194 Prevent the creation of ObjectType[UnknownType] when converting VariableDescriptor #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverting VariableDescriptor
guillaume-dequenne-sonarsource
force-pushed
the
SONARPY-2194
branch
from
973caa9 to
29e98b3
Compare
|
guillaume-dequenne-sonarsource
requested a review
from maksim-grebeniuk-sonarsource
guillaume-dequenne-sonarsource
changed the title
| .map(fqn -> ctx.lazyTypesContext().getOrCreateLazyTypeWrapper(fqn)) | ||
| .orElse(TypeWrapper.UNKNOWN_TYPE_WRAPPER); | ||
| return new ObjectType(typeWrapper); | ||
| .map(t -> (PythonType) new ObjectType(t)) |
There was a problem hiding this comment.
minor: this chain lambdas could be replaced with method references:
return Optional.ofNullable(from.annotatedType())
.map(ctx.lazyTypesContext()::getOrCreateLazyTypeWrapper)
.map(ObjectType::new)
.map(PythonType.class::cast)
.orElse(PythonType.UNKNOWN);There was a problem hiding this comment.
Thanks, I hesitated between the 2 approaches and somehow preferred the one in the code (neither of them really please me though tbh...), so I'll keep it that way.
maksim-grebeniuk-sonarsource
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-21194