Update rule metadata (#1070)

SonarSource · May 3, 2023 · 974798e · 974798e
1 parent 45b4d58
commit 974798e
Show file tree

Hide file tree

Showing 47 changed files with 41 additions and 129 deletions.
diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S1313.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S1313.json
@@ -6,9 +6,7 @@
     "func": "Constant\/Issue",
     "constantCost": "30min"
   },
-  "tags": [
-    "owasp-a3"
-  ],
+  "tags": [],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1313",
   "sqKey": "S1313",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S1523.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S1523.json
@@ -7,8 +7,7 @@
     "constantCost": "30min"
   },
   "tags": [
-    "cwe",
-    "owasp-a1"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-1523",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2041.html b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2041.html
@@ -10,4 +10,6 @@ <h2>Compliant Solution</h2>
 echo "Hello";
 echo "Hello","World!";
 </pre>
+<h2>Deprecated</h2>
+<p>This rule is deprecated; use {rule:php:S6600} instead.</p>
 
diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2041.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2041.json
@@ -1,14 +1,12 @@
 {
   "title": "Parentheses should not be used for calls to \"echo\"",
   "type": "CODE_SMELL",
-  "status": "ready",
+  "status": "deprecated",
   "remediation": {
     "func": "Constant\/Issue",
     "constantCost": "2min"
   },
-  "tags": [
-    "pitfall"
-  ],
+  "tags": [],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2041",
   "sqKey": "S2041",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2053.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2053.json
@@ -7,9 +7,7 @@
     "constantCost": "30min"
   },
   "tags": [
-    "cwe",
-    "sans-top25-porous",
-    "owasp-a3"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2053",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2068.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2068.json
@@ -7,9 +7,7 @@
     "constantCost": "30min"
   },
   "tags": [
-    "cwe",
-    "sans-top25-porous",
-    "owasp-a2"
+    "cwe"
   ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-2068",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2077.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2077.json
@@ -8,8 +8,6 @@
   },
   "tags": [
     "cwe",
-    "owasp-a1",
-    "sans-top25-insecure",
     "bad-practice",
     "sql"
   ],

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2092.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2092.json
@@ -8,9 +8,7 @@
   },
   "tags": [
     "cwe",
-    "privacy",
-    "sans-top25-porous",
-    "owasp-a3"
+    "privacy"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-2092",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2115.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2115.json
@@ -7,9 +7,7 @@
     "constantCost": "45min"
   },
   "tags": [
-    "cwe",
-    "owasp-a2",
-    "owasp-a3"
+    "cwe"
   ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-2115",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2245.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2245.json
@@ -7,9 +7,7 @@
     "constantCost": "10min"
   },
   "tags": [
-    "cwe",
-    "owasp-a3",
-    "owasp-m5"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2245",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2277.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2277.json
@@ -7,10 +7,7 @@
     "constantCost": "20min"
   },
   "tags": [
-    "cwe",
-    "owasp-a6",
-    "sans-top25-porous",
-    "owasp-a3"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2277",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2278.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2278.json
@@ -7,9 +7,7 @@
     "constantCost": "20min"
   },
   "tags": [
-    "cwe",
-    "owasp-a6",
-    "sans-top25-porous"
+    "cwe"
   ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-2278",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2612.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2612.json
@@ -7,9 +7,7 @@
     "constantCost": "5min"
   },
   "tags": [
-    "cwe",
-    "sans-top25-porous",
-    "owasp-a5"
+    "cwe"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2612",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2755.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S2755.json
@@ -7,8 +7,7 @@
     "constantCost": "15min"
   },
   "tags": [
-    "cwe",
-    "owasp-a4"
+    "cwe"
   ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-2755",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3330.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3330.json
@@ -8,9 +8,7 @@
   },
   "tags": [
     "cwe",
-    "sans-top25-insecure",
-    "privacy",
-    "owasp-a7"
+    "privacy"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-3330",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3333.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3333.json
@@ -8,7 +8,6 @@
   },
   "tags": [
     "cwe",
-    "owasp-a6",
     "php-ini"
   ],
   "defaultSeverity": "Blocker",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3334.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3334.json
@@ -8,8 +8,6 @@
   },
   "tags": [
     "cwe",
-    "owasp-a1",
-    "sans-top25-risky",
     "php-ini"
   ],
   "defaultSeverity": "Blocker",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3335.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3335.json
@@ -8,7 +8,6 @@
   },
   "tags": [
     "cwe",
-    "owasp-a6",
     "php-ini"
   ],
   "defaultSeverity": "Major",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3336.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3336.json
@@ -7,7 +7,6 @@
     "constantCost": "5min"
   },
   "tags": [
-    "owasp-a6",
     "php-ini"
   ],
   "defaultSeverity": "Blocker",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3337.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S3337.json
@@ -8,7 +8,6 @@
   },
   "tags": [
     "cwe",
-    "owasp-a6",
     "php-ini"
   ],
   "defaultSeverity": "Blocker",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4423.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4423.json
@@ -8,11 +8,7 @@
   },
   "tags": [
     "cwe",
-    "privacy",
-    "owasp-a6",
-    "sans-top25-porous",
-    "owasp-a3",
-    "owasp-m3"
+    "privacy"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4423",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4426.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4426.json
@@ -8,10 +8,7 @@
   },
   "tags": [
     "cwe",
-    "privacy",
-    "owasp-a6",
-    "owasp-a3",
-    "owasp-m5"
+    "privacy"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4426",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4433.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4433.json
@@ -7,8 +7,7 @@
     "constantCost": "15min"
   },
   "tags": [
-    "cwe",
-    "owasp-a2"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4433",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4502.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4502.json
@@ -7,9 +7,7 @@
     "constantCost": "5min"
   },
   "tags": [
-    "cwe",
-    "sans-top25-insecure",
-    "owasp-a6"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4502",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4507.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4507.json
@@ -10,8 +10,7 @@
     "cwe",
     "error-handling",
     "debug",
-    "user-experience",
-    "owasp-a3"
+    "user-experience"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-4507",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4790.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4790.json
@@ -4,11 +4,7 @@
   "status": "ready",
   "tags": [
     "cwe",
-    "spring",
-    "owasp-a6",
-    "sans-top25-porous",
-    "owasp-a3",
-    "owasp-m5"
+    "spring"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4790",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4792.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4792.json
@@ -3,10 +3,7 @@
   "type": "SECURITY_HOTSPOT",
   "status": "ready",
   "tags": [
-    "cwe",
-    "owasp-a10",
-    "sans-top25-porous",
-    "owasp-a3"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4792",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4830.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S4830.json
@@ -9,10 +9,7 @@
   "tags": [
     "cwe",
     "privacy",
-    "owasp-a6",
-    "ssl",
-    "owasp-a3",
-    "owasp-m3"
+    "ssl"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4830",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5042.html b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5042.html
@@ -60,7 +60,6 @@ <h2>Compliant Solution</h2>
         $filename = $zip-&gt;getNameIndex($i);
         $stats = $zip-&gt;statIndex($i);
 
-        // Prevent ZipSlip path traversal (S6096)
         if (strpos($filename, '../') !== false || substr($filename, 0, 1) === '/') {
             throw new Exception();
         }
@@ -117,7 +116,6 @@ <h2>Compliant Solution</h2>
 while ($file = zip_read($zip)) {
     $filename = zip_entry_name($file);
 
-    // Prevent ZipSlip path traversal (S6096)
     if (strpos($filename, '../') !== false || substr($filename, 0, 1) === '/') {
         throw new Exception();
     }

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5042.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5042.json
@@ -7,9 +7,7 @@
     "constantCost": "10min"
   },
   "tags": [
-    "cwe",
-    "owasp-a6",
-    "owasp-a5"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-5042",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5122.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5122.json
@@ -3,9 +3,7 @@
   "type": "SECURITY_HOTSPOT",
   "status": "ready",
   "tags": [
-    "cwe",
-    "owasp-a6",
-    "sans-top25-porous"
+    "cwe"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-5122",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5328.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5328.json
@@ -7,8 +7,7 @@
     "constantCost": "15min"
   },
   "tags": [
-    "cwe",
-    "owasp-a6"
+    "cwe"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-5328",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5332.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5332.json
@@ -3,9 +3,7 @@
   "type": "SECURITY_HOTSPOT",
   "status": "ready",
   "tags": [
-    "cwe",
-    "owasp-a3",
-    "owasp-m3"
+    "cwe"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-5332",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5527.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5527.json
@@ -9,10 +9,7 @@
   "tags": [
     "cwe",
     "privacy",
-    "owasp-a6",
-    "ssl",
-    "owasp-a3",
-    "owasp-m3"
+    "ssl"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-5527",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5542.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5542.json
@@ -8,11 +8,7 @@
   },
   "tags": [
     "cwe",
-    "privacy",
-    "owasp-a6",
-    "sans-top25-porous",
-    "owasp-a3",
-    "owasp-m5"
+    "privacy"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-5542",

diff --git a/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5547.json b/php-checks/src/main/resources/org/sonar/l10n/php/rules/php/S5547.json
@@ -8,11 +8,7 @@
   },
   "tags": [
     "cwe",
-    "privacy",
-    "owasp-a6",
-    "sans-top25-porous",
-    "owasp-a3",
-    "owasp-m5"
+    "privacy"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-5547",