-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT SQUASH] SONARKT-424 Kotlin android telemetry metric #523
Conversation
fdb683e
to
db5c66e
Compare
db5c66e
to
9a712de
Compare
sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/telemetry/TelemetryData.kt
Outdated
Show resolved
Hide resolved
sonar-kotlin-plugin/src/main/java/org/sonarsource/kotlin/plugin/KotlinSensor.kt
Outdated
Show resolved
Hide resolved
...otlin-surefire/src/test/java/org/sonarsource/kotlin/surefire/KotlinResourcesLocatorTest.java
Show resolved
Hide resolved
0ff8570
to
2924132
Compare
sonar-kotlin-metrics/src/main/java/org/sonarsource/kotlin/metrics/MetricVisitor.kt
Show resolved
Hide resolved
5f8e061
to
f8e13e7
Compare
its/plugin/src/test/java/org/sonarsource/slang/ExternalReportTest.java
Outdated
Show resolved
Hide resolved
8b2a050
to
08c3afc
Compare
1f4443c
to
8682606
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some questions, let's discuss them together
sonar-kotlin-plugin/src/test/java/org/sonarsource/kotlin/plugin/KotlinRulesDefinitionTest.kt
Outdated
Show resolved
Hide resolved
sonar-kotlin-metrics/src/main/java/org/sonarsource/kotlin/metrics/MetricVisitor.kt
Show resolved
Hide resolved
sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/telemetry/TelemetryData.kt
Outdated
Show resolved
Hide resolved
sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/telemetry/TelemetryData.kt
Outdated
Show resolved
Hide resolved
7aa32ea
to
0956737
Compare
@leveretka I am done address the comments. Back to you for a second round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As discussed, let's split into 2 commits:
- update plugin-api
- add telemetry
0956737
to
090f362
Compare
090f362
to
0f6d668
Compare
I have rewritten the history accordingly. The PR should be mergeable once CI is green. |
Quality Gate passedIssues Measures |
Do not merge: the PR is based on #522Do not squash: SONARKT-424 required Plugin API update, which is done on a dedicated commit
SONARKT-424
Telemetry data: https://dub01.online.tableau.com/#/site/sonarsource/views/SQ-V2Telemetry-byAnalysis/Detailedview?:iid=1