Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT SQUASH] SONARKT-424 Kotlin android telemetry metric #523

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Jan 22, 2025

Do not merge: the PR is based on #522
Do not squash: SONARKT-424 required Plugin API update, which is done on a dedicated commit

SONARKT-424

Telemetry data: https://dub01.online.tableau.com/#/site/sonarsource/views/SQ-V2Telemetry-byAnalysis/Detailedview?:iid=1

@antonioaversa antonioaversa changed the base branch from master to antonio/SONARKT-429-fix-uts-on-windows-with-autocrlf-true January 22, 2025 14:50
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch 6 times, most recently from fdb683e to db5c66e Compare January 23, 2025 14:53
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch from db5c66e to 9a712de Compare January 23, 2025 14:58
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch 8 times, most recently from 0ff8570 to 2924132 Compare January 23, 2025 16:58
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch 3 times, most recently from 5f8e061 to f8e13e7 Compare January 27, 2025 08:20
@antonioaversa antonioaversa marked this pull request as ready for review January 27, 2025 08:22
@antonioaversa antonioaversa changed the title SONARKT-424 Kotlin android metric [DO NOT MERGE] SONARKT-424 Kotlin android metric Jan 27, 2025
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-429-fix-uts-on-windows-with-autocrlf-true branch from 8b2a050 to 08c3afc Compare January 27, 2025 10:52
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch from 1f4443c to 8682606 Compare January 27, 2025 12:34
Base automatically changed from antonio/SONARKT-429-fix-uts-on-windows-with-autocrlf-true to master January 28, 2025 09:50
Copy link
Contributor

@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some questions, let's discuss them together

@antonioaversa antonioaversa changed the title [DO NOT MERGE] SONARKT-424 Kotlin android metric SONARKT-424 Kotlin android metric Jan 29, 2025
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch from 7aa32ea to 0956737 Compare January 29, 2025 13:07
@antonioaversa
Copy link
Contributor Author

@leveretka I am done address the comments. Back to you for a second round.

Copy link
Contributor

@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As discussed, let's split into 2 commits:

  • update plugin-api
  • add telemetry

@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch from 0956737 to 090f362 Compare January 30, 2025 09:21
@antonioaversa antonioaversa changed the title SONARKT-424 Kotlin android metric [DO NOT SQUASH] SONARKT-424 Kotlin android metric Jan 30, 2025
@antonioaversa antonioaversa changed the title [DO NOT SQUASH] SONARKT-424 Kotlin android metric [DO NOT SQUASH] SONARKT-424 Kotlin android telemetry metric Jan 30, 2025
@antonioaversa antonioaversa force-pushed the antonio/SONARKT-424-kotlin-android-metric branch from 090f362 to 0f6d668 Compare January 30, 2025 09:26
@antonioaversa
Copy link
Contributor Author

LGTM!

As discussed, let's split into 2 commits:

  • update plugin-api
  • add telemetry

I have rewritten the history accordingly. The PR should be mergeable once CI is green.

@leveretka leveretka merged commit 96db204 into master Jan 30, 2025
12 checks passed
@leveretka leveretka deleted the antonio/SONARKT-424-kotlin-android-metric branch January 30, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants