SONARJAVA-3317 To improve performance cache JTypeSymbol.memberSymbols

SonarSource · Apr 8, 2020 · ecf8f9f · ecf8f9f
1 parent 50c8c6e
commit ecf8f9f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/java-frontend/src/main/java/org/sonar/java/model/JTypeSymbol.java b/java-frontend/src/main/java/org/sonar/java/model/JTypeSymbol.java
@@ -50,6 +50,11 @@ final class JTypeSymbol extends JSymbol implements Symbol.TypeSymbol {
    */
   private List<Type> interfaces;
 
+  /**
+   * Cache for {@link #memberSymbols()}.
+   */
+  private Collection<Symbol> memberSymbols;
+
   final SpecialField superSymbol = new SpecialField() {
     @Override
     public String name() {
@@ -118,6 +123,13 @@ public List<Type> interfaces() {
 
   @Override
   public Collection<Symbol> memberSymbols() {
+    if (memberSymbols == null) {
+      memberSymbols = convertMemberSymbols();
+    }
+    return memberSymbols;
+  }
+
+  private Collection<Symbol> convertMemberSymbols() {
     Collection<Symbol> members = new ArrayList<>();
     for (ITypeBinding b : typeBinding().getDeclaredTypes()) {
       members.add(sema.typeSymbol(b));

diff --git a/java-frontend/src/test/java/org/sonar/java/model/ClassesLayoutTest.java b/java-frontend/src/test/java/org/sonar/java/model/ClassesLayoutTest.java
@@ -98,8 +98,8 @@ void type() {
   @Test
   void symbol_type() {
     assertAll(
-      () -> assertThat(instanceSize(JTypeSymbol.class, X86_64)).isEqualTo(88),
-      () -> assertThat(instanceSize(JTypeSymbol.class, X86_64_COOPS)).isEqualTo(48)
+      () -> assertThat(instanceSize(JTypeSymbol.class, X86_64)).isEqualTo(96),
+      () -> assertThat(instanceSize(JTypeSymbol.class, X86_64_COOPS)).isEqualTo(56)
     );
   }