Skip to content

Commit

Permalink
SONARJAVA-5055 Update rules metadata (#4830)
Browse files Browse the repository at this point in the history
  • Loading branch information
irina-batinic-sonarsource authored Jun 26, 2024
1 parent 26ad55d commit 6aee51b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ <h2>Sensitive Code Example</h2>
}
</pre>
<h2>Compliant Solution</h2>
<p>Using <a href="https://github.com/awsdocs/aws-doc-sdk-examples/tree/main/javav2/example_code/secretsmanager">AWS Secrets Manager</a>:</p>
<p>Using <a href="https://github.com/awsdocs/aws-doc-sdk-examples/tree/main/javav2/example_code/secrets-manager">AWS Secrets Manager</a>:</p>
<pre>
import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueRequest;
import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueResponse;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h4>Noncompliant code example</h4>
public void updateTodayOrders(Connection connection, List&lt;Order&gt; orders) {
Date today = java.sql.Date.valueOf(LocalDate.now());
String insertQuery = "INSERT INTO Order (id, price, executionDate) VALUES (?, ?, ?)";
PreparedStatement preparedStatement = connection.prepareStatement(SQL_INSERT);
PreparedStatement preparedStatement = connection.prepareStatement(insertQuery);

for(Order order: orders) {
preparedStatement.setString(1, order.id());
Expand All @@ -39,10 +39,9 @@ <h4>Compliant solution</h4>
public void updateTodayOrders(Connection connection, List&lt;Order&gt; orders) {
Date today = java.sql.Date.valueOf(LocalDate.now());
String insertQuery = "INSERT INTO Order (id, price, executionDate) VALUES (?, ?, ?)";
preparedStatement.setDate(3, today); // Compliant

PreparedStatement preparedStatement = connection.prepareStatement(SQL_INSERT);
PreparedStatement preparedStatement = connection.prepareStatement(insertQuery);

preparedStatement.setDate(3, today); // Compliant
for(Order order: orders) {
preparedStatement.setString(1, order.id());
preparedStatement.setString(2, order.price());
Expand Down
2 changes: 1 addition & 1 deletion sonarpedia.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"languages": [
"JAVA"
],
"latest-update": "2024-06-24T09:35:54.811007Z",
"latest-update": "2024-06-26T13:48:56.604262Z",
"options": {
"no-language-in-filenames": true,
"preserve-filenames": false
Expand Down

0 comments on commit 6aee51b

Please sign in to comment.