Fix quality flaw: increase check coverage

SonarSource · Dec 23, 2016 · 10302ab · 10302ab
1 parent 6f5072b
commit 10302ab
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/java-checks/src/test/files/checks/NoTestInTestClassCheck.java b/java-checks/src/test/files/checks/NoTestInTestClassCheck.java
@@ -98,6 +98,19 @@ public class MyCucumberTest { // should not raise an issue
 public class MyCucumber2Test { // no issue
 }
 
+@RunWith(MyRunner.class)
+public class MyCucumber3Test { // Noncompliant - not recognized
+}
+@RunWith(getRunner())
+public class MyCucumber4Test { // Noncompliant - does not compile, not a class literal
+  public Class<? extends Runner> getRunner() {
+    return null;
+  }
+}
+@RunWith(value1= MyRunner.class, value2= YourRunner.class)
+public class MyCucumber5Test { // Noncompliant - does not compile, not a class literal
+}
+
 public class CTest {
   @org.junit.jupiter.api.Test // no issue, junit5 annotation
   public void testFoo() {

diff --git a/java-checks/src/test/java/org/sonar/java/checks/NoTestInTestClassCheckTest.java b/java-checks/src/test/java/org/sonar/java/checks/NoTestInTestClassCheckTest.java
@@ -30,6 +30,7 @@ public class NoTestInTestClassCheckTest {
   @Test
   public void test() {
     JavaCheckVerifier.verify("src/test/files/checks/NoTestInTestClassCheck.java", new NoTestInTestClassCheck());
+    JavaCheckVerifier.verifyNoIssueWithoutSemantic("src/test/files/checks/NoTestInTestClassCheck.java", new NoTestInTestClassCheck());
   }
 
   @Test