Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARGO-109 Mention git submodules in README.md #80

Merged
merged 3 commits into from
Jan 10, 2025
Merged

SONARGO-109 Mention git submodules in README.md #80

merged 3 commits into from
Jan 10, 2025

Conversation

petertrr
Copy link
Contributor

@petertrr petertrr commented Jan 7, 2025 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title [NO-JIRA] Mention git submodules in README.md SONARGO-109 [NO-JIRA] Mention git submodules in README.md Jan 7, 2025
@petertrr petertrr changed the title SONARGO-109 [NO-JIRA] Mention git submodules in README.md SONARGO-109 Mention git submodules in README.md Jan 9, 2025
@petertrr petertrr marked this pull request as ready for review January 9, 2025 12:53
petertrr
petertrr commented Jan 9, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
jonas-wielage-sonarsource
jonas-wielage-sonarsource approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to change the link before merging

@petertrr petertrr enabled auto-merge (squash) January 9, 2025 13:20
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 9, 2025

Quality Gate passed Quality Gate passed for 'Go'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@petertrr petertrr merged commit 9048224 into master Jan 10, 2025
7 checks passed
@petertrr petertrr deleted the petertrr-patch-1 branch January 10, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-wielage-sonarsource jonas-wielage-sonarsource jonas-wielage-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertrr @jonas-wielage-sonarsource