SONARGO-57 Reduce the size of the Go binary #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertrr
force-pushed
the
SONARGO-57
branch
4 times, most recently
from
15a7b26 to
ce70260
Compare
petertrr
changed the title
petertrr
commented
Jan 6, 2025
sonar-go-to-slang/Makefile
Outdated
There was a problem hiding this comment.
Makefile was unused in scripts and not mentioned in the readme 🤷♀️
petertrr
commented
Jan 6, 2025
sonar-go-to-slang/make.sh
Outdated
| GOOS=darwin GOARCH=arm64 ${path_to_binary} build -o build/executable/sonar-go-to-slang-darwin-arm64 "${GO_FLAGS[@]}" | ||
| if command -v musl-gcc &> /dev/null; then | ||
| # This should be run on CI; for a dev environment, this is not essential | ||
| GOOS=linux GOARCH=amd64 CC=musl-gcc ${path_to_binary} build -o build/executable/sonar-go-to-slang-linux-amd64 "${GO_FLAGS[@]}" -ldflags '-linkmode external -extldflags "-s -w -static"' |
There was a problem hiding this comment.
Main reduction (and for all platfroms) is achieved with -ldflags="-s -w" which removes debug info from the binary. However, static linking almost doesn't affect the size (2.3M -> 2.4M) and should make the Linux executable run on wider selection of platforms
|
mstachniuk
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARGO-57