Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARGO-56 Add common CN Github workflows #51

Merged
merged 2 commits into from
Dec 18, 2024
Merged

SONARGO-56 Add common CN Github workflows #51

merged 2 commits into from
Dec 18, 2024

Conversation

mstachniuk
Copy link
Contributor

@mstachniuk mstachniuk commented Dec 17, 2024

SONARGO-56

Part of

@mstachniuk mstachniuk requested a review from petertrr December 18, 2024 08:07
@mstachniuk
Copy link
Contributor Author

I will able to test workflows after merge to master

Copy link
Contributor

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please see my suggestions before merging.

env:
SLACK_WEBHOOK: ${{ fromJSON(steps.secrets.outputs.vault).SLACK_WEBHOOK }}
with:
args: 'Dogfood build for `${{ steps.dogfood.outputs.sha1 }}`: *failed*, see the logs at https://github.com/SonarSource/sonar-iac/actions'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
args: 'Dogfood build for `${{ steps.dogfood.outputs.sha1 }}`: *failed*, see the logs at https://github.com/SonarSource/sonar-iac/actions'
args: 'Dogfood build for `${{ steps.dogfood.outputs.sha1 }}`: *failed*, see the logs at https://github.com/SonarSource/sonar-go/actions'

Or, I think, you can also use https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID

Copy link

Quality Gate passed Quality Gate passed for 'Go'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mstachniuk mstachniuk merged commit 0850e67 into master Dec 18, 2024
7 checks passed
@mstachniuk mstachniuk deleted the SONARGO-56 branch December 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants