Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARGO-82 Add "artifactory-configuration" to common Gradle modules #44

Merged
merged 5 commits into from
Dec 17, 2024
Merged

SONARGO-82 Add "artifactory-configuration" to common Gradle modules #44

merged 5 commits into from
Dec 17, 2024

Conversation

petertrr
Copy link
Contributor

@petertrr petertrr commented Dec 13, 2024 •
edited
Loading

SONARGO-82

Verified: No significant differences in buildinfo.json and uploaded .pom files

@petertrr petertrr force-pushed the SONARGO-82 branch 3 times, most recently from 281326d to 9c39bda Compare December 17, 2024 10:50
@petertrr petertrr marked this pull request as ready for review December 17, 2024 11:03
@petertrr petertrr requested a review from mstachniuk December 17, 2024 11:03
mstachniuk
mstachniuk approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and see my comments

.cirrus.yml Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
@petertrr petertrr force-pushed the SONARGO-82 branch 9 times, most recently from caa5172 to 2420546 Compare December 17, 2024 13:47
@petertrr petertrr requested a review from mstachniuk December 17, 2024 14:07
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'Go'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@petertrr petertrr merged commit 6394f5b into master Dec 17, 2024
8 checks passed
@petertrr petertrr deleted the SONARGO-82 branch December 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstachniuk mstachniuk Awaiting requested review from mstachniuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertrr @mstachniuk