SONARGO-52 Create a new repository for common Gradle scripts #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Manifest and Badges * Fix Badge image
Update dependencies and migrate to version catalogs
petertrr
commented
Dec 11, 2024
| [submodule "build-logic"] | ||
| path = build-logic | ||
| url = https://github.com/SonarSource/cloud-native-gradle-modules | ||
| branch = SONARGO-52 |
There was a problem hiding this comment.
Temporary, until SonarSource/cloud-native-gradle-modules#1 is merged
petertrr
commented
Dec 11, 2024
| java.sourceCompatibility = JavaVersion.VERSION_17 | ||
| tasks.withType(JavaCompile) { | ||
| options.encoding = "UTF-8" | ||
| options.release = java.sourceCompatibility.majorVersion as int |
There was a problem hiding this comment.
Already default behavior
| @@ -30,11 +31,6 @@ dependencies { | |||
| testRuntimeOnly testLibs.junit.jupiter.engine | |||
| } | |||
|
|
|||
| tasks.withType(JavaCompile) { | |||
| // Prevent warning: Gradle 5.0 will ignore annotation processors | |||
| options.compilerArgs += [ "-proc:none" ] | |||
There was a problem hiding this comment.
I didn't see any warnings, maybe outdated already?
|
jonas-wielage-sonarsource
force-pushed
the
master
branch
from
b186fe4 to
7e4becb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARGO-52