Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARGO-40 Vulnerability imported through external report Golangci lint should be set to Security in Software Quality #32

Closed
wants to merge 5 commits into from

Conversation

mstachniuk
Copy link
Contributor

@mstachniuk mstachniuk commented Dec 10, 2024

SONARGO-40

Part of

@mstachniuk mstachniuk requested a review from petertrr December 10, 2024 16:12
Copy link
Contributor

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mstachniuk mstachniuk changed the title SONARGO-40 Vulnerability imported through external report Golangci li… SONARGO-40 Vulnerability imported through external report Golangci lint should be set to Security in Software Quality Dec 10, 2024
@mstachniuk
Copy link
Contributor Author

Added extra logic to not set impact for SonarQube Cloud. Inspiration: SonarSource/sonar-php@2c2926f#diff-f62646dcbc99379245eab4c360267b4caad694a07f1d7a7de6ed6153c8999c85R114

@mstachniuk mstachniuk requested a review from petertrr December 11, 2024 11:28
Copy link

@mstachniuk
Copy link
Contributor Author

The issue requires more complicated solution, the followup epic: https://sonarsource.atlassian.net/browse/SONARGO-76

@mstachniuk mstachniuk closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants