Code review remarks

Co-authored-by: Peter Trifanov <[email protected]>
SonarSource · Dec 11, 2024 · ba01903 · ba01903
1 parent a99b300
commit ba01903
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/sonar-go-plugin/src/main/java/org/sonar/go/externalreport/GolangCILintReportSensor.java b/sonar-go-plugin/src/main/java/org/sonar/go/externalreport/GolangCILintReportSensor.java
@@ -91,14 +91,14 @@ protected RuleKey createRuleKey(String source, RuleType ruleType, Severity ruleS
     @Override
     protected List<Impact> impacts(String severity, String source) {
       var isSonarCloud = context.runtime().getProduct() == SonarProduct.SONARQUBE && context.runtime().getEdition() == SonarEdition.SONARCLOUD;
-      if (!isSonarCloud) {
+      if (isSonarCloud) {
         // SonarQube Cloud does not yet support the `impact` field for external issues
-        if (GOSEC.equals(source)) {
-          return List.of(new Impact(SoftwareQuality.SECURITY, org.sonar.api.issue.impact.Severity.MEDIUM));
-        }
-        return List.of(new Impact(SoftwareQuality.MAINTAINABILITY, org.sonar.api.issue.impact.Severity.MEDIUM));
+        return List.of();
       }
-      return List.of();
+      if (GOSEC.equals(source)) {
+        return List.of(new Impact(SoftwareQuality.SECURITY, org.sonar.api.issue.impact.Severity.MEDIUM));
+      }
+      return List.of(new Impact(SoftwareQuality.MAINTAINABILITY, org.sonar.api.issue.impact.Severity.MEDIUM));
     }
   }
 }