JS-597 Remove 'sonar-runtime' from codebase #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdiez
approved these changes
Mar 4, 2025
zglicz
commented
Mar 5, 2025
| const config = extendRuleConfig( | ||
| [{ enum: SONAR_RUNTIME, title: SONAR_CONTEXT }], | ||
| // @ts-ignore | ||
| { sonarKey: 'some-rule', meta: {}, schema: [{ title: SONAR_CONTEXT }] }, |
There was a problem hiding this comment.
this existing schema was and is not valid. I'll remove it soon, but for now just ignore it. During runtime it seems to be fine.
| @@ -119,6 +118,9 @@ void test() { | |||
| ) | |||
| ) | |||
| ).isEmpty(); | |||
| assertThat( | |||
| buildResult.getLogsLines(l -> l.matches(".*INFO: Work dir received: .*[/|\\\\].scannerwork$")) | |||
There was a problem hiding this comment.
thats specific to windows? Is this test also ran on a sane platform?
There was a problem hiding this comment.
its are also run on windows, yes. when checking logs for paths or validating paths in general, windows may fail if u always use forward slashes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-597
Part of