Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-594 Remove eslint scope #5151

Merged
merged 2 commits into from
Mar 3, 2025
Merged

JS-594 Remove eslint scope #5151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97d00a7
Remove dependency on eslint-scope
zglicz Mar 1, 2025
0fa9c68
fix imports
zglicz Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
"@inquirer/prompts": "^7.1.0",
"@types/babel__preset-env": "7.10.0",
"@types/bytes": "3.1.5",
"@types/eslint-scope": "3.7.7",
"@types/estree": "1.0.6",
"@types/express": "4.17.21",
"@types/functional-red-black-tree": "1.0.6",
Expand Down Expand Up @@ -116,7 +115,6 @@
"eslint-plugin-jsx-a11y": "6.10.2",
"eslint-plugin-react": "7.37.4",
"eslint-plugin-react-hooks": "5.1.0",
"eslint-scope": "8.2.0",
"express": "4.21.2",
"form-data": "4.0.2",
"functional-red-black-tree": "1.0.1",
Expand Down
5 changes: 2 additions & 3 deletions packages/jsts/src/rules/S5725/rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@
*/
// https://sonarsource.github.io/rspec/#/rspec/S5725/javascript

import type { Rule } from 'eslint';
import { Rule, Scope } from 'eslint';
import estree from 'estree';
import type { TSESTree } from '@typescript-eslint/utils';
import { Variable } from 'eslint-scope';
import {
generateMeta,
getTypeAsString,
Expand All @@ -39,7 +38,7 @@ export const rule: Rule.RuleModule = {
if (!isRequiredParserServices(services)) {
return {};
}
function shouldReport(assignedVariable: Variable) {
function shouldReport(assignedVariable: Scope.Variable) {
let nbSrcAssignment = 0;
let hasUnsafeSrcAssignment = false;
let hasIntegrityAssignment = false;
Expand Down