Fixing squid:S2275 -Fixing squid:UselessParenthesesCheck #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id3de673d50ad22c690eb854371ee3995d9eef258 Signed-off-by: smisger <[email protected]>
|
@misgersameer could you provide a single pull request to address all quality flaws that you'd like to fix? |
| @@ -86,7 +86,7 @@ public ChangeLogHandler getChangeLog(DateRange dateRange) { | |||
| LOG.info("Getting change log information for %s\n", baseDir.getAbsolutePath()); | |||
| if (!hgRepo.initFrom(baseDir)) { | |||
| throw new HgRepositoryNotFoundException( | |||
| String.format("Can't find repository in: %s\n",baseDir.getAbsolutePath())); | |||
| String.format("Can't find repository in: %s%n",baseDir.getAbsolutePath())); | |||
There was a problem hiding this comment.
@misgersameer this change seems incorrect, and is unrelated to redundant parentheses
There was a problem hiding this comment.
%n should be used in place of \n to produce the platform-specific line separator
more info can be found at https://dev.eclipse.org/sonar/rules/show/squid:S2275
|
@dbolkensteyn i need to fix them one by, surely i combine when there is a small fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule " UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding, squid:S2275 - Printf-style format strings should not lead to unexpected behavior at runtime. You can find more information about the issues here:
https://dev.eclipse.org/sonar/rules/show/squid:S2275
https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck
Please let me know if you have any questions.
Sameer Misger