Skip to content

Commit

Permalink
8.0 Use try/except when importing external libs (#8)
Browse files Browse the repository at this point in the history
[FIX] LINT

Use try/except when importing external libs
Remove self.ensure_one() that has nothing to do in an api.model method
  • Loading branch information
Alexis de Lattre authored and pedrobaeza committed Oct 19, 2016
1 parent 4ef7cb6 commit 34b08c2
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 18 deletions.
1 change: 0 additions & 1 deletion account_invoice_import/wizard/account_invoice_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,6 @@ def _create_invoice(self, parsed_inv):

@api.model
def post_process_invoice(self, parsed_inv, invoice):
self.ensure_one()
invoice.button_reset_taxes()
# Force tax amount if necessary
prec = self.env['decimal.precision'].precision_get('Account')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,17 @@
from openerp.exceptions import Warning as UserError
import os
from tempfile import mkstemp
import logging
from invoice2data.main import extract_data
from invoice2data.template import read_templates
from invoice2data.main import logger as loggeri2data
import pkg_resources

import logging
logger = logging.getLogger(__name__)

try:
from invoice2data.main import extract_data
from invoice2data.template import read_templates
from invoice2data.main import logger as loggeri2data
except ImportError:
logger.debug('Cannot import invoice2data')


class AccountInvoiceImport(models.TransientModel):
_inherit = 'account.invoice.import'
Expand Down
14 changes: 9 additions & 5 deletions account_invoice_zugferd/models/account_invoice.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,19 @@
from openerp.tools import float_compare, float_is_zero, float_round
from StringIO import StringIO
from lxml import etree
from PyPDF2 import PdfFileWriter, PdfFileReader
from PyPDF2.generic import DictionaryObject, DecodedStreamObject,\
NameObject, createStringObject, ArrayObject
from tempfile import NamedTemporaryFile
from datetime import datetime
import logging
# from pprint import pprint

logger = logging.getLogger(__name__)

try:
from PyPDF2 import PdfFileWriter, PdfFileReader
from PyPDF2.generic import DictionaryObject, DecodedStreamObject,\
NameObject, createStringObject, ArrayObject
except ImportError:
logger.debug('Cannot import PyPDF2')


ZUGFERD_LEVEL = 'comfort'
ZUGFERD_FILENAME = 'ZUGFeRD-invoice.xml'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@
from openerp import models, api, _
from openerp.tools import float_compare
from openerp.exceptions import Warning as UserError
import PyPDF2
from lxml import etree
from StringIO import StringIO
import mimetypes
from urlparse import urlparse
import logging

logger = logging.getLogger(__name__)

try:
import PyPDF2
except ImportError:
logger.debug('Cannot import PyPDF2')


class BusinessDocumentImport(models.AbstractModel):
_name = 'business.document.import'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
try:
import phonenumbers
except ImportError:
logger.warning('Cannot import phonenumbers')
logger.debug('Cannot import phonenumbers')


class BusinessDocumentImport(models.AbstractModel):
Expand Down
7 changes: 5 additions & 2 deletions base_ubl/models/ubl.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@
from lxml import etree
from StringIO import StringIO
from tempfile import NamedTemporaryFile
import PyPDF2
import mimetypes
import logging

logger = logging.getLogger(__name__)

try:
import PyPDF2
except ImportError:
logger.debug('Cannot import PyPDF2')


class BaseUbl(models.AbstractModel):
_name = 'base.ubl'
Expand Down
6 changes: 4 additions & 2 deletions sale_order_import_csv/wizard/sale_order_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
from openerp.exceptions import Warning as UserError
from openerp.tools import float_compare
from tempfile import TemporaryFile
import unicodecsv
import logging

logger = logging.getLogger(__name__)
try:
import unicodecsv
except ImportError:
logger.debug('Cannot import unicodecsv')


class SaleOrderImport(models.TransientModel):
Expand Down

0 comments on commit 34b08c2

Please sign in to comment.