Skip to content

Potential fix for build-time compilation error #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steve-salmond
Copy link

This change is intended to address a compilation error that crops up in BaseValue.cs when building a project. Looks like 'return value' should potentially be 'return originalValue' instead?

image

This change is intended to address a compilation error that crops up in BaseValue.cs when building a project.  Looks like 'return value' should potentially be 'return originalValue' instead?
@szunami
Copy link

szunami commented Nov 8, 2022

FYI I've hit this too. Given the amount of time that has passed here, I'm pursuing a fork (see: openupm/openupm#3535)

@joeyzhouhaiyi
Copy link

FYI I've hit this too. Given the amount of time that has passed here, I'm pursuing a fork (see: openupm/openupm#3535)

Hey man, how do you use the patched package?

@CharlieHess
Copy link

Hey man, how do you use the patched package?

The easiest way is to install the OpenUPM CLI, then do:

openupm remove com.solidalloy.generic-scriptable-architecture

Followed by:

openupm add com.szunami.generic-scriptable-architecture

That will automatically update your scoped registries and manifest.json. If you'd rather do it by hand:

"scopedRegistries": [
    {
      "name": "package.openupm.com",
      "url": "https://package.openupm.com",
      "scopes": [
        "com.openupm",
        "com.solidalloy",
        "com.solidalloy.extevents",
        "com.solidalloy.generic-unity-objects",
        "com.solidalloy.type-references",
        "com.solidalloy.unity-dropdown",
        "com.solidalloy.util",
        "com.szunami.generic-scriptable-architecture",
        "org.nuget",
        "org.nuget.system.buffers",
        "org.nuget.system.memory",
        "org.nuget.system.numerics.vectors",
        "org.nuget.system.runtime.compilerservices.unsafe"
      ]
    }
  ],
"dependencies": {
  ...
  "com.szunami.generic-scriptable-architecture": "1.4.2",
  ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants