Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a how_tos file to show an example of settle a message using negative acknowledgement #45

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

khoigithub
Copy link

No description provided.

Copy link
Contributor

@gszol gszol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

from howtos.sampler_boot import SolaceConstants, SamplerBoot, BasicTestMessageHandler
from howtos.sampler_master import SamplerMaster

X = TypeVar('X')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only tried a quick case sensitive search in my browser, but this seems unused.

receiver.receive_async(message_handler)

HowToPublishPersistentMessage.publish_string_message_non_blocking(publisher, topic, message)
event.wait(5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe print the stats at the end.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok sounds good, I will print the stats down below

@TrentDaniel
Copy link
Collaborator

@gszol, what's the state of this PR? How much work is left for this sample?

@gszol
Copy link
Contributor

gszol commented Aug 30, 2024

@gszol, what's the state of this PR? How much work is left for this sample?

It's good to go, it just has to wait till the release to go public.

@TamimiGitHub
Copy link
Contributor

I'm assuming this will also require a bump in the solace package version in the requirements.txt file correct?

Copy link
Contributor

@gszol gszol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK. More in line with the established "sampler" style than I ever could go.

This line does nothing though, I even tried running it after deleting it in case it's something magical:
X = TypeVar('X')

I don't have write access to the source repo, so I'm not sure what's the simplest way to go about deleting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants