-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a how_tos file to show an example of settle a message using negative acknowledgement #45
base: main
Are you sure you want to change the base?
Conversation
…tle of message using negative acknowledgement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
from howtos.sampler_boot import SolaceConstants, SamplerBoot, BasicTestMessageHandler | ||
from howtos.sampler_master import SamplerMaster | ||
|
||
X = TypeVar('X') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only tried a quick case sensitive search in my browser, but this seems unused.
receiver.receive_async(message_handler) | ||
|
||
HowToPublishPersistentMessage.publish_string_message_non_blocking(publisher, topic, message) | ||
event.wait(5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe print the stats at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok sounds good, I will print the stats down below
@gszol, what's the state of this PR? How much work is left for this sample? |
It's good to go, it just has to wait till the release to go public. |
I'm assuming this will also require a bump in the solace package version in the requirements.txt file correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK. More in line with the established "sampler" style than I ever could go.
This line does nothing though, I even tried running it after deleting it in case it's something magical:
X = TypeVar('X')
I don't have write access to the source repo, so I'm not sure what's the simplest way to go about deleting it.
No description provided.