Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioned queues #42

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Partitioned queues #42

merged 6 commits into from
Feb 1, 2024

Conversation

SravanThotakura05
Copy link
Collaborator

No description provided.

@SravanThotakura05 SravanThotakura05 self-assigned this Jan 30, 2024
@SravanThotakura05 SravanThotakura05 linked an issue Jan 30, 2024 that may be closed by this pull request
@ozangunalp
Copy link
Collaborator

Do we need to do anything with SolaceIncomingChannel#onStateChange ? Is the partition handoff transparent to the consumer?

@SravanThotakura05
Copy link
Collaborator Author

SravanThotakura05 commented Jan 30, 2024

Do we need to do anything with SolaceIncomingChannel#onStateChange ? Is the partition handoff transparent to the consumer?

This indicates whether the consumer is in active or passive state in case of durable exclusive queue as it will have only one active consumer. The state is returned by Java API. We can use this for logging purpose.

Partition handoff is handled between Java API and broker. For client consumer it is just another queue.

@ozangunalp
Copy link
Collaborator

The code looks good, can we rebase and merge?

@SravanThotakura05
Copy link
Collaborator Author

I am just checking if anything else need to be added. I will merge this PR later

@SravanThotakura05 SravanThotakura05 linked an issue Feb 1, 2024 that may be closed by this pull request
@SravanThotakura05 SravanThotakura05 marked this pull request as ready for review February 1, 2024 06:53
@SravanThotakura05
Copy link
Collaborator Author

@ozangunalp can you approve this Pull request

@SravanThotakura05 SravanThotakura05 merged commit 345151d into main Feb 1, 2024
3 checks passed
@SravanThotakura05 SravanThotakura05 deleted the partitioned-queues branch February 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Partitioned Queues Trailing direct receiver instance in the incoming channel
2 participants