Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #39 #36 #40

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Fixed #39 #36 #40

merged 5 commits into from
Jan 29, 2024

Conversation

SravanThotakura05
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I forgot about the missing-resource-creation-strategy=create-on-start

I noted a couple of changes that'll make the example a bit more coherent.

Also, I've noted that in dev mode the queue.dynamic.topic incoming channels consume messages from the beginning of the queue, and I see in the Solace UI that "messages queued" get stacked up. Does that mean we have problem with sending acknowledgements to the broker?

@SravanThotakura05
Copy link
Collaborator Author

👍 I forgot about the missing-resource-creation-strategy=create-on-start

I noted a couple of changes that'll make the example a bit more coherent.

Also, I've noted that in dev mode the queue.dynamic.topic incoming channels consume messages from the beginning of the queue, and I see in the Solace UI that "messages queued" get stacked up. Does that mean we have problem with sending acknowledgements to the broker?

Earlier we are creating a outbound message with ack and nack callbacks which used to trigger acks to broker. Since we removed it i believe it is not calling the ack method which sends ack to broker

@ozangunalp
Copy link
Collaborator

Ok actually this exposes something missing from the SolaceInboundMessage. For the message ack composition to work we need to override getAck / getNack methods in the message implementation.
Like this:

    @Override
    public Supplier<CompletionStage<Void>> getAck() {
        return this::ack;
    }

@SravanThotakura05
Copy link
Collaborator Author

@ozangunalp all comments are addressed

@ozangunalp ozangunalp merged commit e487786 into main Jan 29, 2024
3 checks passed
@SravanThotakura05 SravanThotakura05 deleted the issues branch January 30, 2024 07:33
@SravanThotakura05 SravanThotakura05 self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants