-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use minetest.conf for settings #45
Open
Poikilos
wants to merge
5
commits into
Sokomine:master
Choose a base branch
from
Poikilos:use-minetest-conf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and correct setting type (change MAX_STATIONS_PER_NETWORK to int).
Panquesito7
reviewed
Aug 7, 2019
Panquesito7
reviewed
Aug 7, 2019
Panquesito7
reviewed
Aug 7, 2019
Co-Authored-By: Panquesito7 <[email protected]>
Co-Authored-By: Panquesito7 <[email protected]>
Co-Authored-By: Panquesito7 <[email protected]>
Panquesito7
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks perfect! 👍
https://github.com/mt-mods/travelnet which is an updated fork of this repo would welcome your patch. As it enables to have one instance of the mod installed system-wide for a world-specific configuration. |
oversword
added a commit
to oversword/travelnet
that referenced
this pull request
Feb 10, 2022
* Remove the usage of pos2str using context var * Make sure on punch and paging is working * Generate formspecs on interact, not on update * Linting and page_formspec usage * Clear metadata formspec on interact * Consolidate ordered formspec function * Reduce repetition in infotext when updating station
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now config.lua uses minetest.conf settings for variables that would normally be configurable, instead of containing only hard-coded settings. The settingtypes.txt file included with this pull request describes the settings following Minetest standards.