Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few changes #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A few changes #4

wants to merge 1 commit into from

Conversation

VanessaE
Copy link

@VanessaE VanessaE commented Feb 23, 2017

Three tweaks:
Don't register cottages straw - default farming mod provides that.
Don't register cottages wool - default wool mod provides it.
Don't register cottages roof nodes if moreblocks is installed - moreblocks PR#69 provides equivalent straw stair/slab nodes via stairsplus.
Replace most wool and darkage-straw texture references with default textures since the they are so similar.

items rather, alias them to the equivalents in moreblocks instead. don't
register cottages straw or wool anymore, alias them to farming straw and
white wool.
@Sokomine
Copy link
Owner

You're right that some nodes can be removed.
cottages:wool and cottages:straw will now be created as aliasses if possible.
roof.lua provides many more roof shapes than just straw. Sadly, even the two starw roof nodes that have corresponding ones in default cannot be aliassed because the stair straw from default/farming does not look well on roofs. Individual straws are aligned vertically in the farming stairs - not horizontally as is needed for a good roof.

sfence pushed a commit to sfence/cottages that referenced this pull request Jun 14, 2021
API for add fle threshing floor products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants