7.5.5 update #3
Open
7.5.5 update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our setTimeout and requestAnimationFrame methods added dispose handlers so that they get cancelled if the component is disposed before they get a chance to run. However, we were only clearing out these dispose handlers if we cleared the timeout or the rAF manually. Instead make sure that we remove the dispose handler when it is no longer needed. Fixes videojs#5199.
…to listen to the window object in addition to DOM objects. (videojs#5255)" (videojs#5301) This reverts commit 7fd29b4. With this change, playing back HLS content via VHS caused an infinite event loop to be printed out. See issue videojs#5281
setSource is useful if you care to be fiddling with the source or doing some work depending on what source is set. However, sometimes, you don't need a setSource and want the middleware to always be selected. Now, if setSource is missing, it will implicitly be included in the middleware chain.
Upgrade to VHS 1.1.0 to pick up the easier overrideNative option.
…g via google closure compiler (videojs#5342)
This exposes `deregisterPlugin` on the videojs alongside `registerPlugin`.
…igger (videojs#5332) Trigger the change event on the next tick. This means that multiple changes to a track's mode will only result in a single change event on its associated TextTrackList rather than 3 events as it may be currently. Fixes videojs#5159
Angular CLI, and potentially other projects, may use the "pure_getters" compression option of uglify which will end up removing the getter line we use for side-effects to update the active cues. This update makes sure that the line doesn't get removed. Fixes videojs#5131
…5371) It's possible for us to get a blob url for sourceset, but when we do, we shouldn't update the source caches with that information. blob urls can arise when playback is done via Media Source Extension (MSE) such as m3u8 sources with @videojs/http-streaming (VHS).
Because we add Touch Activity in the parent class and those don't actually get removed in Resize Manager we leak on every dispose. Calling super.dispose() cleans them up because we remove our list of handlers via a call to DomData.removeData Fixes videojs#5339
Karma 3.0.0 drops support for node 4.
If Promise is available or if Promise is polyfilled, then we'll return a new Promise from `play()` that will get fulfilled with the value returned from the `play()` method. This means that on IE11, this promise will get resolved when we call `play()` even if play doesn't succeed. We will have a follow-on PR to polyfill this behavior and resolve or reject the promise for browsers like IE11 that don't return a promise from `play()`.
…ng Live UI at extra small size (videojs#5915)
…lay promise to resolve (videojs#5876) Calling video.load while the video is trying to play (that is between play and playing event) throws an error. Instead, just wait for playback to happen before resetting. Fixes videojs#5875
This fixes a regression created by videojs#5741.
For non-prefixed APIs, check directly against the fullscreen element rather than using the cached value. Fixes videojs#5814.
…m fields within the player (videojs#5969)
Change comprises of commenting out event.stopPropagation calls added in a recent bug fix. The following comment was added in affected places: Videojs 7.5.5 has added event stopPropagation throughout its components to fix some hotkeys behaviour, such as reacting to hotkeys insie of forms inside the player. This broke our keyhandling implemenation, preventing any remote key presses from being handled. See more here: - videojs@79eadac - videojs#5969 The reasons to stop propagation don't seem to apply to our usecase, so it should be safe to leave this commented out. If this causes problems in the future, the alternative solution would perhaps be to use rewrite our key handling to go through the hotkeys system: https://github.com/videojs/video.js/blob/cf6e0e824814f3ccb061b057a9aa5eff3b54ba6e/docs/guides/options.md#useractionshotkeys
|
@catalin-ursachi, this commit fixes the remote control issues: 933eb38 |
When resolving merge conflicts from 7.5.5 update, some changes from our fork got surpressed. Upon revisting, they look like up-to-date and shoudl be left in, as based on commit #52424c92b21d9bf40c95b361fd134fbe3c7ad2b0
Dont seek on button press
Currently calls undefined methods on the techs which causes crashes. If they are not defined it is because they are not supported, this will help to reduce the number of stub methods and improve stability.
VCP-1155: Add check for existence on tech call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades videojs library to 7.5.5
THIS SHOULD NOT BE MERGED, as using it directly by current C5Player will break.
PR raised to review code changes and agree direction only.
TODO:
MIGRATION TODOleft after mergeRelated core player review: https://jira.softwire.com/fisheye/cru/CR-C5VIDEOJS-121
This change is