-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(10/1): harmonization #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 67 commits
534a60b
3abdc37
2e5cbb7
12a3fc8
eed8914
77a7280
af271eb
863b5d9
7862cc0
54742d8
7e9311d
f69e45b
e4b97c2
9689b14
f645755
b054912
08e0a9d
99fbbc5
fdf5a2d
5139ba0
1d15e47
3bbe5f7
3342c77
922c5bf
25dfe2a
de8dce1
f1dee46
2948cb3
bd67b24
e35856d
f963da4
392448e
b113b01
1fbc87a
ef2f8f4
2d4f02d
24183fe
7d2fd12
d23f1a9
53f29ae
49599b0
d73b110
f036813
58870f4
2f56747
83e0c5c
f5d3a09
a27af0f
10a8ae7
fbf1da9
bb4f295
5109ca6
e515ddd
f4ee31c
89629c6
ddf9e11
620b8fb
199d50f
9a84613
cd2bd93
6fbb0ae
c7a8c1c
1c5aa71
8a6f352
9b06399
84ea22b
7287b3c
9d3d197
578decf
f999aae
517fa53
80bacf9
b73d7ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,3 +6,4 @@ use flake | |||||
|
||||||
export DATABASE_URL=sqlite://episko.db | ||||||
export RUSTUP_TOOLCHAIN=stable | ||||||
export PATH="$PATH:/home/simon/2_Uni/se/episko/target/debug" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Consider using a relative path instead of hardcoded absolute path The current PATH addition contains a hardcoded absolute path with a specific username ( -export PATH="$PATH:/home/simon/2_Uni/se/episko/target/debug"
+export PATH="$PATH:$(pwd)/target/debug" This change makes the path relative to the current directory, ensuring it works for all developers regardless of where they cloned the repository. 📝 Committable suggestion
Suggested change
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
name: Build Gui Application | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
- alpha | ||
- beta | ||
- next | ||
pull_request: | ||
workflow_dispatch: | ||
|
||
concurrency: | ||
group: build-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
build-tauri: | ||
permissions: | ||
contents: write | ||
strategy: | ||
fail-fast: true | ||
|
||
runs-on: 'ubuntu-24.04' | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Setup Bun | ||
uses: oven-sh/setup-bun@v2 | ||
with: | ||
bun-version: latest | ||
- run: bun i | ||
|
||
- name: install Rust stable | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: Rust Cache | ||
uses: Swatinem/rust-cache@v2 | ||
|
||
- name: install dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf | ||
|
||
- name: Build Tauri | ||
run: bun tauri build | ||
|
||
- name: Build Cli | ||
run: cargo build -p episko_cli |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,6 @@ jobs: | |
maxColorRange: 3 | ||
invertColorRange: true | ||
|
||
|
||
- name: Validate frontend linting | ||
run: bun check | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ node_modules | |
/.svelte-kit | ||
/build | ||
coverage | ||
utils/fake-data* | ||
|
||
# OS | ||
.DS_Store | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Replace hardcoded path with a relative path
The current path contains a hardcoded username and directory structure that is specific to your local environment. This will cause issues for other developers who clone the repository.
Consider replacing it with a relative path:
This ensures the script works across different development environments.
📝 Committable suggestion