Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 version of orcaslicer #8418

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

CodeMasterCody3D
Copy link

Description

Screenshots/Recordings/Graphs

Screenshot_20250214-041132_TermuxX11

Tests

@@ -48,63 +41,64 @@ jobs:
matrix:
include:
- os: ubuntu-20.04
- os: ubuntu-24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeMasterCody3D what is the reason for removing 24.04 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing and just switched to 22.04 instead. I didn't dig further just decided to use what I had figured out so I could get this code to you guys that are way smarter than me. I basically found out about arm runners And decided to give it a shot. I am not a programmer And I used ChatGPT to do lots of modifying and testing them i decided to try this myself and it was an easy modification getting the arm runner to work but I used ChatGPT to do the modification for me. I am a super noob. I was just determined to get arm64 version of orcaslicer built using the runners so it would be in the upstream. Sorry for the lengthy explanation. You can add it back I just didn't wanna deal with it

I forgot to mention I had to add this to it as well to make the build work.

sudo apt-get -y update
sudo apt-get remove -y libunwind-*
sudo apt-get -y install --no-install-recommends libgstreamer1.0-dev

Copy link
Author

@CodeMasterCody3D CodeMasterCody3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not really that good at all this so if I could get some input so I could learn a little more about how all this works. I'm learning using chatgpt, I want to be able to fix build all yml file so It can be accepted. Any recommendations? Can you try fixing it to where it uses 24.04 as well? There is an arm version of 24.04 as well same naming scheme as the 22.04 arm. ubuntu-22.04-arm, ubuntu-24.04-arm I am a super noob but I am learning so I would love feed back and help, with a short explanation so I can understand it and go look up what I need to know to know more. Thank you

@@ -48,63 +41,64 @@ jobs:
matrix:
include:
- os: ubuntu-20.04
- os: ubuntu-24.04
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing and just switched to 22.04 instead. I didn't dig further just decided to use what I had figured out so I could get this code to you guys that are way smarter than me. I basically found out about arm runners And decided to give it a shot. I am not a programmer And I used ChatGPT to do lots of modifying and testing them i decided to try this myself and it was an easy modification getting the arm runner to work but I used ChatGPT to do the modification for me. I am a super noob. I was just determined to get arm64 version of orcaslicer built using the runners so it would be in the upstream. Sorry for the lengthy explanation. You can add it back I just didn't wanna deal with it

I forgot to mention I had to add this to it as well to make the build work.

sudo apt-get -y update
sudo apt-get remove -y libunwind-*
sudo apt-get -y install --no-install-recommends libgstreamer1.0-dev

@haunter1982 haunter1982 mentioned this pull request Feb 17, 2025
1 task
Removed cache check
Removed cache/fix
Trying to fix
Not using cache this time
I think I may have it not using cache now
Combined build deps and build all together for now.
Added deps build to build all with no cache
- 'build_release_vs2022.bat'
- 'build_release_macos.sh'

workflow_dispatch:
Copy link
Collaborator

@Noisyfox Noisyfox Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you ran a code formatter against these files which does not preserve comments.
Generally speaking, try avoid doing unnecessary changes to the file, especially formatting the entire file. It's usually acceptable if you only reformat the part that you changed (with that said, still it's better to follow the code style of the rest of the part if possible). Otherwise the PR will be hard to review with all these unrelated destractions, and also this could create unnecessary conflicts to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants