Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't disable solid infill pattern option unless no infill & top/bottom surfaces #8375

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Don't disable solid infill pattern option unless no infill & top/bottom surfaces #8375

merged 2 commits into from
Feb 19, 2025

Conversation

Noisyfox
Copy link
Collaborator

Fix #8370

@henrivdr
Copy link
Contributor

I'm speechless. Only 7 hours from Issue to PR.
Well done @Noisyfox 💪🏼

SoftFever
SoftFever approved these changes Feb 19, 2025
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you

@SoftFever SoftFever merged commit 5e541f8 into SoftFever:main Feb 19, 2025
12 checks passed
@Noisyfox Noisyfox deleted the bugfox/infill-pattern-options branch February 19, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal solid infill pattern setting inappropriately disabled with zero top or bottom shell layers
3 participants
@Noisyfox @henrivdr @SoftFever