gcode viewer: fix column width calculation #8294
Conversation
For a locales with long enough "Used filament" localization, line type table may render crooked with overlapping column headers. This change reworks column width calculations getting rid of heuristics based on the presence of "Display" column.
|
Those changes are split out of #7409 |
|
i assume this is not required if #8198 approved |
|
I see. I'll check it using your change then. This change is simply picked out of original PR. |
|
@yw4z , with your changes issue is still there, but UX will not suffer much with "Usage" localization less than 14 characters. For example, here are russian locale with longest "Usage" translation I know - "Использование". Your PR:
Your PR with current one:
|
|
Thanks for reporting, yes this one still required. i thought that will be shorter. but it seems much shorter compared to "used filaments" in russian |
|
I'm on LInux. And I forgot I have setting for the imgui scaling which is set to 0.8 and FreeType enabled. Here are how your PR looks without any of my changes with russian localization:
|
|
Oh ok that looks normal now, still i have to fine tune colors for light appearance |
Description
Some locales have really long messages for line type statistics headers. Such a long messages causing strings overlapping with end result getting hard to read.
Rework column width calculation to take into account merged columns.
Correctly calculate header width as a bold font.
Screenshots/Recordings/Graphs