-
-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: ERS - Option to limit ERS to external perimeters and overhangs only #7399
base: main
Are you sure you want to change the base?
Enhancement: ERS - Option to limit ERS to external perimeters and overhangs only #7399
Conversation
Hi, sounds as really cool feature! |
Yes I have them all on my dev branch here: https://github.com/igiannakas/OrcaSlicer/actions/runs/11783977166 |
Hi, @igiannakas . I tested a bit the build with your modifications. |
Nope it should only be applied to external perimeters specifically for overhang regions. To avoid artefacts from rapid acceleration and deceleration when moving in and away from sharp overhangs. |
These look perfect! Well done on taming the S1!! |
Description
Extrusion rate smoothing can materially help smooth out speed transitions during overhangs, leading to better external finish. This is similar to the latest bambu slicer release where speed transition smoothing has been introduced.
However current implementation applies smoothing to all features which will increase print time with marginal benefit visually.
Therefore, this PR introduces an option to limit ERS to the areas that are visible to the user, reducing print time impact.
Debating whether to enable this option by default when ERS is enabled, as internal features do not benefit much from extrusion rate smoothing compared to slowdown for overhangs that does materially benefit especially for printers with high accelerations, where PA cannot keep up with the requested speed changes over time.
Screenshots/Recordings/Graphs
Tests
Basic regression tests done-no adverse impact with it disabled to the existing feature. Enabled limits only to external perimeters & overhangs.