Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: ERS - Option to limit ERS to external perimeters and overhangs only #7399

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Nov 6, 2024

Description

Extrusion rate smoothing can materially help smooth out speed transitions during overhangs, leading to better external finish. This is similar to the latest bambu slicer release where speed transition smoothing has been introduced.

However current implementation applies smoothing to all features which will increase print time with marginal benefit visually.

Therefore, this PR introduces an option to limit ERS to the areas that are visible to the user, reducing print time impact.

Debating whether to enable this option by default when ERS is enabled, as internal features do not benefit much from extrusion rate smoothing compared to slowdown for overhangs that does materially benefit especially for printers with high accelerations, where PA cannot keep up with the requested speed changes over time.

Screenshots/Recordings/Graphs

image

Tests

Basic regression tests done-no adverse impact with it disabled to the existing feature. Enabled limits only to external perimeters & overhangs.

@igiannakas igiannakas marked this pull request as ready for review November 6, 2024 19:32
@igiannakas igiannakas changed the title Option to limit ERS to external perimeters and overhangs only Enhancement: Option to limit ERS to external perimeters and overhangs only Nov 6, 2024
@igiannakas igiannakas changed the title Enhancement: Option to limit ERS to external perimeters and overhangs only Enhancement: ERS - Option to limit ERS to external perimeters and overhangs only Nov 6, 2024
@lookypanda
Copy link

Hi, sounds as really cool feature!
Is there any way to somehow download the orca build with all three of your ERS improvements at once?
I would like to test it.

@igiannakas
Copy link
Contributor Author

Yes I have them all on my dev branch here: https://github.com/igiannakas/OrcaSlicer/actions/runs/11783977166

@lookypanda
Copy link

lookypanda commented Nov 17, 2024

Hi, @igiannakas . I tested a bit the build with your modifications.
Should ERS be applied on the top surface?
Because when the external perimeters option are ticked, ERS is not applied on the top surface, but maybe it could be useful there. (But I haven't tested how much the ERS is really needed on the top surface).

@igiannakas
Copy link
Contributor Author

Nope it should only be applied to external perimeters specifically for overhang regions. To avoid artefacts from rapid acceleration and deceleration when moving in and away from sharp overhangs.

@lookypanda
Copy link

Over the past few days I have tested the build with all 3 new ERS improvements on about 5 prints.
No problems have been detected. ERS works as it should, slowing down before and after overhangs.
printer Ender 3 S1 on klipper
Thanks for a great work and a great feature!

photo_5325701332293772835_y
photo_5325701332293772834_y
photo_5325701332293772833_y
photo_5325701332293772832_y

@igiannakas
Copy link
Contributor Author

These look perfect! Well done on taming the S1!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants