Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon fixes and improvements #6204

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented Jul 21, 2024

Let me know if you found more issues related icons

TODO

• Paint icons glitches near edges. image with 8x zoom
Screenshot-20240721195027
• Home page > Orca logo
• Home page > Context menu folder icon
• Project page default icon
• pellets.svg ( appears on filament titlebar after pellet extruder enabled )
• tab_multi_active.svg
• Project page > match document icons
• Project page > Sidebar icons
• Menubar > File > Open project > match icon with new "Open project" icon used on home page
• Toolchanger icons
• Revert icon close to text / checkbox on parameters
• Adaptive Pressure advance

AMS icon blurry and rendered with wrong resolution

causes by its using different resolution from other sidebar icons. It uses 18x18 in code but other sidebar elements using 16x16 changed this in code. i was designed icon as 16x16 previously
before
Screenshot-20240721153958
after
Screenshot-20240721153914

BBL printers > Device / Calibration tab > Printer icon blurry

icon not uses correct resolution on code. matched size with icon on device tab
before
Screenshot-20240721194403

after
Screenshot-20240721194309

Search icon looks dimmed

Anti aliasing reduces strength of colors on lines if they diagonal or circular. Thats why icon looks a bit dimmed compared to other icon. I increased line thickness by %20 for search icon to fix this
Tested on windows but anti aliasing might be work differently on other systems. I didnt increased line thickness above 1.2 to reduce chance of looks bolder compared to other icons. Also results might be differently on high dpi screens
I'm not planning to this on all icons but search icon is always visible and one of main elements. so want to fix this for it
before after (change is minor but noticeable on regular usage)
Screenshot-20240721154713

Home Page > new / open buttons

before
Screenshot-20240721185010

after
Screenshot-20240721184912

Home Page > dummy thumbnails

most dummy thumbnail images has a minimal landscape illustrations. i tried a cube like object but it felt so empty. this one looks cool imo

before
Screenshot-20240721185122

after
Screenshot-20240721193323

Home Page > context menu icons

matched style and shape of icons with previously designed icons

before
Screenshot-20240721185415

after
Screenshot-20240721185408

Setup Filaments > Custom Filament Edit Button

before
Screenshot-20240721192708

after
Screenshot-20240721192625

@discip
Copy link
Contributor

discip commented Jul 23, 2024

@yw4z

before Screenshot-20240721185415

after Screenshot-20240721185408

Please keep these icons they look much better!
Especially the red trash bin. The red accent color is just right here and doesn't disturb the overall color scheme.

The new icons make it look pretty dull.

@yw4z
Copy link
Contributor Author

yw4z commented Jul 23, 2024

@discip used on same designed icon with other delete / remove icon on UI to keep consistency. Trash icon looks a bit outdated. But i understand your concern about accidentally clicking remove menu item. there is few workaround for this
• Using red color while hovering menu item background
• Using red colored icon
And there is only 2 item on context menu. i dont think you will struggle too much

About folder icon, i will make a redesign for it. keep following process

@discip
Copy link
Contributor

discip commented Jul 23, 2024

  1. Trash icon looks a bit outdated.

What about an X.

  1. • Using red color while hovering menu item background

Combined with 1. this could be the way to go.

  1. About folder icon, i will make a redesign for it. keep following process

Let's see what you've got. 😊

@yw4z
Copy link
Contributor Author

yw4z commented Jul 23, 2024

@discip i will look a better solution but dont expect much for context menu :) i guess moving remove / open folders to directly on the thumbnail will be better for future. its already used on project thumbnails. probably folder icon will use bottom-right corner. so that will remove possibility of accidental clicks
Screenshot-20240723164602

button will be visible only when hover
Screenshot-20240721182555

i added this to my list but my list a bit long so i cant make it soon

@yw4z yw4z mentioned this pull request Jul 28, 2024
57 tasks
@SoftFever
Copy link
Owner

Thank you @yw4z !

Overall looks fine to me.

I have to suggestions:

  1. I agree with @discip that old icon is more intuitive
    image
  2. The new open icon is not intuitive. A straight arrow doesn't convey the message well.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants