-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[constraint] makes BarycentricCenterEffector inherit from PositionEffector #42
[constraint] makes BarycentricCenterEffector inherit from PositionEffector #42
Conversation
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.h
Outdated
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.h
Outdated
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Show resolved
Hide resolved
src/SoftRobots.Inverse/component/constraint/BarycentricCenterEffector.inl
Outdated
Show resolved
Hide resolved
…ffector.h Co-authored-by: Alex Bilger <[email protected]>
@alxbilger thanks for your review. I think we can merge now 😊 |
|
||
cMatrix.endEdit(); | ||
m_nbLines = cIndex - constraintIndex; | ||
template<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you added this right? I did not think about specialization for rigids when I did my suggestions. Have a look if you could use DataTypes::CPos
to try to factorize the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well. I've made the changes. The only difference was the normalization of the orientation in the case of a Rigid.
So I've factorized the code by adding a setBarycenter()
function which normalize the orientation in the case of a Rigid. It makes sens, even though it hides/disconnects the normalization after the accumulate
. But I'm fine with it.
I'm sorry I really need this to be merged. |
This PR makes
BarycentricCenterEffector
inherit fromPositionEffector
which allows to:weight
,directions
, anduseDirections
Rigid3
Additionally:
initData()
which I removed from the component because we use the initialization ofPositionEffector
now.I'm not sure about the way I handled the deprecation warnings.