Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] update ci.yml #12

Merged
merged 5 commits into from
Jan 29, 2024
Merged

[ci] update ci.yml #12

merged 5 commits into from
Jan 29, 2024

Conversation

EulalieCoevoet
Copy link
Member

No description provided.

@EulalieCoevoet
Copy link
Member Author

@olivier-roussel Hello Olivier, I'm sorry I've duplicated what you were doing in #9, I forgot about this PR.

In addition there is a bit of cleaning and I propose to use sofa_with_sofapython3: 'true' instead of looking for the release. SoftRobots CI is now working and has the master release needed for SoftRobots.Inverse CI to work.

The only remaining problem is the tests run on Windows and I have no idea of what could be wrong. Is that the same problem you were having? (the logs have been deleted)

@olivier-roussel
Copy link
Contributor

olivier-roussel commented Jan 9, 2024

Hi @EulalieCoevoet, ok nice, I think I was not aware of sofa_with_sofapython3 option for the github CI.
I don't think this is same bug I had, I don't remind it exactly since it's been a while, but I think if I got this error 127 (which looks like telling the test binary does not exists or is not executable), I would most probably have checked if the file actually exists (it looks like it is linked successfully in the logs by adding some ls commands here in the CI to understand what is going on (maybe the binary is in some $WORKSPACE_BUILD_PATH\tests\bin instead of $WORKSPACE_BUILD_PATH\bin for example ?, as some testing related code has probably changed). And I guess I would remember having doing so if I did.

@olivier-roussel
Copy link
Contributor

olivier-roussel commented Jan 9, 2024

So the file seems to be at the right place in $WORKSPACE_BUILD_PATH\bin, with the correct permissions.
The only things that come to my mind is that the LD_LIBRARY_PATH variable here looks like to be defined as a list of paths separated by :, but I guess it should be ; on Windows to avoid confusion with drive letter such as D:.
Sorry I'm out of ideas right now for this... I can try to have a look later when I'll have a bit of time.

@EulalieCoevoet
Copy link
Member Author

The only things that come to my mind is that the LD_LIBRARY_PATH variable here looks like to be defined as a list of paths separated by :, but I guess it should be ; on Windows to avoid confusion with drive letter such as D:.

It seems okay here https://github.com/SofaDefrost/SoftRobots/actions/runs/7448042980/job/20261540240

@EulalieCoevoet
Copy link
Member Author

@olivier-roussel what's your OS ? If windows, does SoftRobots.Inverse_test.exe run on your computer ?

@olivier-roussel
Copy link
Contributor

No I'm running linux

@EulalieCoevoet
Copy link
Member Author

Hello @alxbilger, could you try SoftRobots.Inverse_test.exe on your machine ?

@EulalieCoevoet
Copy link
Member Author

Well let's merge, so that it works at least on ubuntu and macos.

@EulalieCoevoet EulalieCoevoet merged commit 30f0ad3 into main Jan 29, 2024
6 of 8 checks passed
@EulalieCoevoet EulalieCoevoet deleted the EulalieCoevoet-patch-1 branch January 29, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants