Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #74

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix ci #74

merged 2 commits into from
Aug 28, 2023

Conversation

olivier-roussel
Copy link
Contributor

Propagates #73 into master.
This PR fixes the following points in the CI:

  • The softprops/action-gh-release Github action used in the CI to deploy assets was incorrectly configured to the master branch (default behavior), instead of the current release set by the sofa_branch field in the build-and-test matrix. This lead to the following undesired behavior:
    • source code archives (zip and tar) were generated from master branch instead of release branch. Other assets (releases for Windows, Linux and MacOS) were generated from correct branch.
    • release tag pushed by this action (tag in the form release-<version>) was incorrectly set to master branch, which is invalid when current release is not master (such as v<version>)
  • Allow the creation of the release to continue on failure, which typically occurs if one asset is missing such the macOS archive as the mac CI is down.

Similarly to what has been proposed to SofaPython3, SoftRobots, STLIB, Cosserat and BeamAdapter plugins.

@alxbilger
Copy link
Member

Is there still the error when retrieving SOFA?

@olivier-roussel
Copy link
Contributor Author

olivier-roussel commented Aug 25, 2023

Unfortunately yes. There seem to have several accumulated reasons that broke the two layers of redundancy to get SOFA binaries in sofa-setup-action.

  • For master only, there is no release of SOFA available on Github. So the CI fallback to Jenkins. For other releases such as v23.06, there are SOFA releases available on Github, so the CI will directly download them from Github without any trouble (and this is why we don't observe the problem on release branches).
  • When falling back on Jenkins, there is still the fact that the Jenkins seem to require some authentication to download the binaries through curl. And I don't see any auth in the Github actions.
    - Also, since today, the url used in curl does seem to match anymore the nightly-generate-binaries.
    I really don't get what is going on with Jenkins, but my actions are very limited. I have few knowledge with it and in any case no admin rights to get into.

My thought are that they are some work in progress on Jenkins right now, so we can't really rely on it, so why not considering to have a master release also available on Github ? (so, solving the first point)

@alxbilger
Copy link
Member

CI works again. I merge

@alxbilger alxbilger merged commit 2aab84b into SofaDefrost:master Aug 28, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants