Fix warnings

Socolin · Apr 1, 2024 · e55f08b · e55f08b
1 parent 9e8dee5
commit e55f08b
Show file tree

Hide file tree

Showing 48 changed files with 80 additions and 153 deletions.
diff --git a/backend/Naheulbook.sln.DotSettings b/backend/Naheulbook.sln.DotSettings
@@ -1,4 +1,5 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=NUnitAssertMigration/@EntryIndexedValue">DO_NOT_SHOW</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_STYLE/@EntryValue">Space</s:String>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_SIMPLE_ACCESSORHOLDER_ON_SINGLE_LINE/@EntryValue">True</s:Boolean>
 	<s:String x:Key="/Default/CustomTools/CustomToolsData/@EntryValue"></s:String>

diff --git a/backend/src/Naheulbook.Core/Actions/Executor/AddCustomModifierExecutor.cs b/backend/src/Naheulbook.Core/Actions/Executor/AddCustomModifierExecutor.cs
@@ -8,9 +8,7 @@
 
 namespace Naheulbook.Core.Actions.Executor;
 
-public interface IAddCustomModifierExecutor : IActionExecutor
-{
-}
+public interface IAddCustomModifierExecutor : IActionExecutor;
 
 public class AddCustomModifierExecutor(ICharacterHistoryUtil characterHistoryUtil) : IAddCustomModifierExecutor
 {

diff --git a/backend/src/Naheulbook.Core/Actions/Executor/AddEaExecutor.cs b/backend/src/Naheulbook.Core/Actions/Executor/AddEaExecutor.cs
@@ -6,9 +6,7 @@
 
 namespace Naheulbook.Core.Actions.Executor;
 
-public interface IAddEaExecutor : IActionExecutor
-{
-}
+public interface IAddEaExecutor : IActionExecutor;
 
 public class AddEaExecutor(ICharacterHistoryUtil characterHistoryUtil) : IAddEaExecutor
 {

diff --git a/backend/src/Naheulbook.Core/Actions/Executor/AddEffectExecutor.cs b/backend/src/Naheulbook.Core/Actions/Executor/AddEffectExecutor.cs
@@ -1,5 +1,4 @@
-using System.Collections.Generic;
-using System.Linq;
+using System.Linq;
 using System.Threading.Tasks;
 using Naheulbook.Core.Exceptions;
 using Naheulbook.Core.Notifications;
@@ -9,9 +8,7 @@
 
 namespace Naheulbook.Core.Actions.Executor;
 
-public interface IAddEffectExecutor : IActionExecutor
-{
-}
+public interface IAddEffectExecutor : IActionExecutor;
 
 public class AddEffectExecutor(ICharacterHistoryUtil characterHistoryUtil) : IAddEffectExecutor
 {
@@ -95,11 +92,6 @@ INotificationSession notificationSession
             }).ToList(),
         };
 
-        if (context.TargetCharacter.Modifiers == null)
-        {
-            context.TargetCharacter.Modifiers = new List<CharacterModifierEntity>();
-        }
-
         context.TargetCharacter.Modifiers.Add(characterModifier);
 
         context.TargetCharacter.AddHistoryEntry(characterHistoryUtil.CreateLogAddModifier(context.TargetCharacter, characterModifier));

diff --git a/backend/src/Naheulbook.Core/Actions/Executor/AddEvExecutor.cs b/backend/src/Naheulbook.Core/Actions/Executor/AddEvExecutor.cs
@@ -6,9 +6,7 @@
 
 namespace Naheulbook.Core.Actions.Executor;
 
-public interface IAddEvExecutor : IActionExecutor
-{
-}
+public interface IAddEvExecutor : IActionExecutor;
 
 public class AddEvExecutor(ICharacterHistoryUtil characterHistoryUtil) : IAddEvExecutor
 {

diff --git a/backend/src/Naheulbook.Core/Actions/Executor/AddItemExecutor.cs b/backend/src/Naheulbook.Core/Actions/Executor/AddItemExecutor.cs
@@ -7,9 +7,7 @@
 
 namespace Naheulbook.Core.Actions.Executor;
 
-public interface IAddItemExecutor : IActionExecutor
-{
-}
+public interface IAddItemExecutor : IActionExecutor;
 
 public class AddItemExecutor(IItemFactory itemFactory) : IAddItemExecutor
 {

diff --git a/backend/src/Naheulbook.Core/Actions/Executor/RemoveItemExecutor.cs b/backend/src/Naheulbook.Core/Actions/Executor/RemoveItemExecutor.cs
@@ -6,9 +6,7 @@
 
 namespace Naheulbook.Core.Actions.Executor;
 
-public interface IRemoveItemExecutor : IActionExecutor
-{
-}
+public interface IRemoveItemExecutor : IActionExecutor;
 
 public class RemoveItemExecutor(IItemUtil itemUtil) : IRemoveItemExecutor
 {

diff --git a/backend/src/Naheulbook.Core/Clients/LaPageAMelkorClient.cs b/backend/src/Naheulbook.Core/Clients/LaPageAMelkorClient.cs
@@ -1,4 +1,6 @@
+using System;
 using System.Collections.Generic;
+using System.ComponentModel.DataAnnotations;
 using System.Net.Http;
 using System.Threading.Tasks;
 using Naheulbook.Shared.Extensions;
@@ -13,6 +15,13 @@ public interface ILaPageAMelkorClient
 
 public class LaPageAMelkorClient(HttpClient client) : ILaPageAMelkorClient
 {
+    [Serializable]
+    public class Options
+    {
+        [Required]
+        public required string Url { get; set; }
+    }
+
     public async Task<ICollection<string>> GetRandomNameAsync(string url)
     {
         var response = await client.GetAsync(url);

diff --git a/backend/src/Naheulbook.Core/Exceptions/EffectNotFoundException.cs b/backend/src/Naheulbook.Core/Exceptions/EffectNotFoundException.cs
@@ -2,6 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class EffectNotFoundException : Exception
-{
-}
+public class EffectNotFoundException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/ForbiddenAccessException.cs b/backend/src/Naheulbook.Core/Exceptions/ForbiddenAccessException.cs
@@ -2,6 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class ForbiddenAccessException : Exception
-{
-}
+public class ForbiddenAccessException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/GroupAlreadyInCombatException.cs b/backend/src/Naheulbook.Core/Exceptions/GroupAlreadyInCombatException.cs
@@ -2,7 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class GroupAlreadyInCombatException : Exception
-{
-
-}
+public class GroupAlreadyInCombatException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/GroupDateNotSetException.cs b/backend/src/Naheulbook.Core/Exceptions/GroupDateNotSetException.cs
@@ -2,7 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class GroupDateNotSetException : Exception
-{
-
-}
+public class GroupDateNotSetException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/GroupNotInCombatException.cs b/backend/src/Naheulbook.Core/Exceptions/GroupNotInCombatException.cs
@@ -2,7 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class GroupNotInCombatException : Exception
-{
-
-}
+public class GroupNotInCombatException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/InvalidCustomDurationActionException.cs b/backend/src/Naheulbook.Core/Exceptions/InvalidCustomDurationActionException.cs
@@ -1,10 +1,10 @@
 using System;
 
-// ReSharper disable UnusedAutoPropertyAccessor.Local
-
 namespace Naheulbook.Core.Exceptions;
 
+[Serializable]
 public class InvalidCustomDurationActionException(string customDurationType) : Exception
 {
+    // ReSharper disable once UnusedMember.Local
     private string CustomDurationType { get; } = customDurationType;
 }
diff --git a/backend/src/Naheulbook.Core/Exceptions/InvalidPasswordException.cs b/backend/src/Naheulbook.Core/Exceptions/InvalidPasswordException.cs
@@ -2,6 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class InvalidPasswordException : Exception
-{
-}
+public class InvalidPasswordException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/InvalidUserActivationCodeException.cs b/backend/src/Naheulbook.Core/Exceptions/InvalidUserActivationCodeException.cs
@@ -2,6 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class InvalidUserActivationCodeException : Exception
-{
-}
+public class InvalidUserActivationCodeException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/NotChargeLeftOnItemException.cs b/backend/src/Naheulbook.Core/Exceptions/NotChargeLeftOnItemException.cs
@@ -2,7 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class NotChargeLeftOnItemException : Exception
-{
-
-}
+public class NotChargeLeftOnItemException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/SpecialityNotFoundException.cs b/backend/src/Naheulbook.Core/Exceptions/SpecialityNotFoundException.cs
@@ -2,7 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class SpecialityNotFoundException : Exception
-{
-
-}
+public class SpecialityNotFoundException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/TargetNotFoundException.cs b/backend/src/Naheulbook.Core/Exceptions/TargetNotFoundException.cs
@@ -2,7 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class TargetNotFoundException : Exception
-{
-
-}
+public class TargetNotFoundException : Exception;
diff --git a/backend/src/Naheulbook.Core/Exceptions/UserAlreadyExistsException.cs b/backend/src/Naheulbook.Core/Exceptions/UserAlreadyExistsException.cs
@@ -2,6 +2,4 @@
 
 namespace Naheulbook.Core.Exceptions;
 
-public class UserAlreadyExistsException : Exception
-{
-}
+public class UserAlreadyExistsException : Exception;
diff --git a/backend/src/Naheulbook.Core/Notifications/INotificationPacket.cs b/backend/src/Naheulbook.Core/Notifications/INotificationPacket.cs
@@ -6,6 +6,4 @@ public interface INotificationPacket
     INotificationPacketPayload Payload { get; }
 }
 
-public interface INotificationPacketPayload
-{
-}
+public interface INotificationPacketPayload;
diff --git a/backend/src/Naheulbook.Core/Services/MonsterCategoryService.cs b/backend/src/Naheulbook.Core/Services/MonsterCategoryService.cs
@@ -1,9 +1,5 @@
 namespace Naheulbook.Core.Services;
 
-public interface IMonsterSubCategoryService
-{
-}
+public interface IMonsterSubCategoryService;
 
-public class MonsterSubCategoryService : IMonsterSubCategoryService
-{
-}
+public class MonsterSubCategoryService : IMonsterSubCategoryService;
diff --git a/backend/src/Naheulbook.Data/Exceptions/RelatedEntitiesNotLoadedException.cs b/backend/src/Naheulbook.Data/Exceptions/RelatedEntitiesNotLoadedException.cs
@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 
 namespace Naheulbook.Data.Exceptions;
 

diff --git a/backend/src/Naheulbook.Data/Repositories/CalendarRepository.cs b/backend/src/Naheulbook.Data/Repositories/CalendarRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface ICalendarRepository : IRepository<CalendarEntity>
-{
-}
+public interface ICalendarRepository : IRepository<CalendarEntity>;
 
 public class CalendarRepository(NaheulbookDbContext context) : Repository<CalendarEntity, NaheulbookDbContext>(context), ICalendarRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/CharacterHistoryEntryRepository.cs b/backend/src/Naheulbook.Data/Repositories/CharacterHistoryEntryRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface ICharacterHistoryEntryRepository : IRepository<CharacterHistoryEntryEntity>
-{
-}
+public interface ICharacterHistoryEntryRepository : IRepository<CharacterHistoryEntryEntity>;
 
 public class CharacterHistoryEntryRepository(NaheulbookDbContext context) : Repository<CharacterHistoryEntryEntity, NaheulbookDbContext>(context), ICharacterHistoryEntryRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/CharacterSkillRepository.cs b/backend/src/Naheulbook.Data/Repositories/CharacterSkillRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface ICharacterSkillRepository : IRepository<CharacterSkillEntity>
-{
-}
+public interface ICharacterSkillRepository : IRepository<CharacterSkillEntity>;
 
 public class CharacterSkillRepository(NaheulbookDbContext naheulbookDbContext) : Repository<CharacterSkillEntity, NaheulbookDbContext>(naheulbookDbContext), ICharacterSkillRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/EffectCategoryRepository.cs b/backend/src/Naheulbook.Data/Repositories/EffectCategoryRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IEffectSubCategoryRepository : IRepository<EffectSubCategoryEntity>
-{
-}
+public interface IEffectSubCategoryRepository : IRepository<EffectSubCategoryEntity>;
 
 public class EffectSubCategoryRepository(NaheulbookDbContext context) : Repository<EffectSubCategoryEntity, NaheulbookDbContext>(context), IEffectSubCategoryRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/EffectTypeRepository.cs b/backend/src/Naheulbook.Data/Repositories/EffectTypeRepository.cs
@@ -3,9 +3,7 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IEffectTypeRepository : IRepository<EffectTypeEntity>
-{
-}
+public interface IEffectTypeRepository : IRepository<EffectTypeEntity>;
 
 
 public class EffectTypeRepository(NaheulbookDbContext naheulbookDbContext) : Repository<EffectTypeEntity, NaheulbookDbContext>(naheulbookDbContext), IEffectTypeRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/GodRepository.cs b/backend/src/Naheulbook.Data/Repositories/GodRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IGodRepository : IRepository<GodEntity>
-{
-}
+public interface IGodRepository : IRepository<GodEntity>;
 
 public class GodRepository(NaheulbookDbContext context) : Repository<GodEntity, NaheulbookDbContext>(context), IGodRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/ItemTypeRepository.cs b/backend/src/Naheulbook.Data/Repositories/ItemTypeRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IItemTypeRepository : IRepository<ItemTypeEntity>
-{
-}
+public interface IItemTypeRepository : IRepository<ItemTypeEntity>;
 
 public class ItemTypeRepository(NaheulbookDbContext context) : Repository<ItemTypeEntity, NaheulbookDbContext>(context), IItemTypeRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/MonsterCategoryRepository.cs b/backend/src/Naheulbook.Data/Repositories/MonsterCategoryRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IMonsterSubCategoryRepository : IRepository<MonsterSubCategoryEntity>
-{
-}
+public interface IMonsterSubCategoryRepository : IRepository<MonsterSubCategoryEntity>;
 
 public class MonsterSubCategoryRepository(NaheulbookDbContext context) : Repository<MonsterSubCategoryEntity, NaheulbookDbContext>(context), IMonsterSubCategoryRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/MonsterTraitRepository.cs b/backend/src/Naheulbook.Data/Repositories/MonsterTraitRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IMonsterTraitRepository : IRepository<MonsterTraitEntity>
-{
-}
+public interface IMonsterTraitRepository : IRepository<MonsterTraitEntity>;
 
 public class MonsterTraitRepository(NaheulbookDbContext context) : Repository<MonsterTraitEntity, NaheulbookDbContext>(context), IMonsterTraitRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/SlotRepository.cs b/backend/src/Naheulbook.Data/Repositories/SlotRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface ISlotRepository : IRepository<SlotEntity>
-{
-}
+public interface ISlotRepository : IRepository<SlotEntity>;
 
 public class SlotRepository(NaheulbookDbContext context) : Repository<SlotEntity, NaheulbookDbContext>(context), ISlotRepository;
diff --git a/backend/src/Naheulbook.Data/Repositories/StatRepository.cs b/backend/src/Naheulbook.Data/Repositories/StatRepository.cs
@@ -3,8 +3,6 @@
 
 namespace Naheulbook.Data.Repositories;
 
-public interface IStatRepository : IRepository<StatEntity>
-{
-}
+public interface IStatRepository : IRepository<StatEntity>;
 
 public class StatRepository(NaheulbookDbContext context) : Repository<StatEntity, NaheulbookDbContext>(context), IStatRepository;