Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft - Update email field to return mail #1259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Microsoft - Update email field to return mail #1259

wants to merge 1 commit into from

Conversation

JosefHarney
Copy link

The base package laravel/socialite has the method getEmail within the class AbstractUser. Within mapUserToObject it is returning userPrincipalName in the email field, therefor getEmail is returning an empty string.

This PR is to return the correct field.

Side note the userPrincipalName is return on #195 of the provider.

atymic
atymic reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the reason for this change? It would be a breaking change, but also it is my understanding the mail property can be changed by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atymic atymic atymic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosefHarney @atymic