-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/set approvedScopes in User #206
Conversation
Now that the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Poke |
@atymic Would it be possible to reopen/merge this PR? |
Let us re-open this issue 👍 It is a better solution than the currently open (draft) PR #225 and is closes #224 Things that need to be addressed:
|
@bilfeldt Re-opened. Maybe we should override the default method, see comment. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
============================================
- Coverage 53.94% 53.94% -0.01%
- Complexity 77 79 +2
============================================
Files 10 10
Lines 228 241 +13
============================================
+ Hits 123 130 +7
- Misses 105 111 +6 ☔ View full report in Codecov by Sentry. |
If laravel/socialite#572 gets merged, this PR brings the approved scopes to SocialiteProviders.